Skip to content

Comments

CI: update macOS runner dependencies#4120

Merged
nilason merged 3 commits intoOSGeo:mainfrom
nilason:ci_mac_upd_deps
Aug 2, 2024
Merged

CI: update macOS runner dependencies#4120
nilason merged 3 commits intoOSGeo:mainfrom
nilason:ci_mac_upd_deps

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Jul 31, 2024

The single most important change to enable newest available version of most packages is the change from jpeg to libjpeg-turbo package.

This is put in draft mode until #4116, #4117 and #4118 are solved.

@nilason nilason added this to the 8.5.0 milestone Jul 31, 2024
@github-actions github-actions bot added the CI Continuous integration label Jul 31, 2024
@nilason nilason added the macOS macOS specific label Jul 31, 2024
@nilason nilason self-assigned this Jul 31, 2024
@echoix
Copy link
Member

echoix commented Jul 31, 2024

Is it possible to change the package names to their updated names (I think gdal conda packaging changed recently), but limit the version of the (single) package that causes the doctests to fail. In other words, if only Python or numpy makes the build fail, we could add a constraint for now.

(This PR might not need to be blocked by the three issues)

@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2024

Added commit with pre-version 2 of Numpy (v 1.26.4) to see what regression Numpy 2 causes by itself.

@echoix
Copy link
Member

echoix commented Jul 31, 2024

Added commit with pre-version 2 of Numpy (v 1.26.4) to see what regression Numpy 2 causes by itself.

Do we know what Python version we get with this and the changes of the PR? (To investigate Python 3.12 vs numpy 2 failures at the same time)

@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2024

Do we know what Python version we get with this and the changes of the PR? (To investigate Python 3.12 vs numpy 2 failures at the same time)

It all in the log: Python version under "Check installed version", packages under "Setup Mamba > micromamba list".

@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2024

Added commit with pre-version 2 of Numpy (v 1.26.4) to see what regression Numpy 2 causes by itself.

Seems only #4116 is caused by Numpy 2 alone.

Will try with Python 3.11 and Numpy 2.

@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2024

Will try with Python 3.11 and Numpy 2.

With that setting all three files errors.

@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2024

Interesting, with Python 3.11.9 with Numpy 1.26.4 the two issues #4117 and #4118 also fails. Some other dependency upgrade(s) is causing them...

@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2024

Interesting, with Python 3.11.9 with Numpy 1.26.4 the two issues #4117 and #4118 also fails. Some other dependency upgrade(s) is causing them...

Could it be the change of GEOS from 3.11 to 3.12?

@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2024

Interesting, with Python 3.11.9 with Numpy 1.26.4 the two issues #4117 and #4118 also fails. Some other dependency upgrade(s) is causing them...

Could it be the change of GEOS from 3.11 to 3.12?

Sure it must be, https://libgeos.org/posts/2023-06-27-geos-3-12-released/:

Change WKTWriter defaults output dimension to 4 and trim to ‘on’ (GH-915, Mike Taves)

@echoix
Copy link
Member

echoix commented Jul 31, 2024

I was just about to write it back here:
At the end of
https://libgeos.org/posts/2023-06-27-geos-3-12-released/

Change WKTWriter defaults output dimension to 4 and trim to ‘on’ (GH-915, Mike Taves)

libgeos/geos#915

And also libgeos/geos#903 might be of concern. Maybe that's why (dimensions changed) some windows tests try to allocate an array of couple terabytes.

@github-actions github-actions bot added vector Related to vector data processing C Related code is in C libraries labels Aug 1, 2024
@nilason nilason marked this pull request as ready for review August 1, 2024 11:33
@nilason
Copy link
Contributor Author

nilason commented Aug 1, 2024

This is ready for review. And mergeable after #4123 is merged.

(I'm not familiar enough with the pygrass lib to address the Numpy 2 issue #4116, so for the time being I'm pinning the version to 1.x).

@nilason nilason merged commit a342ea8 into OSGeo:main Aug 2, 2024
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
nilason added a commit that referenced this pull request Nov 5, 2024
@nilason nilason modified the milestones: 8.5.0, 8.4.1 Nov 5, 2024
@nilason
Copy link
Contributor Author

nilason commented Nov 5, 2024

Backported with 926cf21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C CI Continuous integration libraries macOS macOS specific vector Related to vector data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants