lib/vector: fix always true if-condition in Vect_point_buffer2()#4115
Merged
nilason merged 1 commit intoOSGeo:mainfrom Jul 31, 2024
Merged
lib/vector: fix always true if-condition in Vect_point_buffer2()#4115nilason merged 1 commit intoOSGeo:mainfrom
nilason merged 1 commit intoOSGeo:mainfrom
Conversation
The true if-statement only handles buffers with rounded corners. E.g. using `v.buffer` without `-s` on points. GEOS handles buffers with corners.
github-actions
bot
added
vector
echoix
reviewed
Jul 31, 2024
echoix
approved these changes
Jul 31, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
…eo#4115) The true if-statement only handles buffers with rounded corners. E.g. using `v.buffer` without `-s` on points. GEOS handles buffers with corners.
Contributor
Author
|
This is needed for the CI runner in 8.4 branch to succeed. Any objections to backport? |
neteler
pushed a commit
that referenced
this pull request
Nov 6, 2024
The true if-statement only handles buffers with rounded corners. E.g. using `v.buffer` without `-s` on points. GEOS handles buffers with corners.
Member
I have backported it. |
neteler
removed
the
backport to 8.4
Contributor
Author
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The true if-statement only handles buffers with rounded corners. E.g. using
v.bufferwithout-son points. GEOS handles buffers with corners.Building with Clang 18 a compiler warning is issued:
which in combination with
-Werrorcauses build failure.(Part of preparation for upgrading dependencies for the macOS CI runner).