v.out.ogr: adds basic unit tests#3848
Merged
wenzeslaus merged 17 commits intoOSGeo:mainfrom Jul 31, 2024
Merged
Conversation
github-actions
bot
added
vector
neteler
changed the title
wenzeslaus
requested changes
Jun 17, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Just a detail. Pylint would report the same.
wenzeslaus
reviewed
Jun 18, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Please, see the other PR for comments on comments.
Member
|
I'm about to approve it, but what were the comments of the other PR that Vaclav was referring to? They have been addressed? |
echoix
previously approved these changes
Jul 31, 2024
wenzeslaus
reviewed
Jul 31, 2024
wenzeslaus
approved these changes
Jul 31, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
This looks good and the comments look good. Thank you for the updates!
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jul 31, 2024
Add basic tests for GeoPackage and Shapefile export which use import to test the result (so they test round trip but focus on the export).
landam
added a commit
to landam/grass
that referenced
this pull request
Jul 31, 2024
This reverts commit 42ef646.
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
Add basic tests for GeoPackage and Shapefile export which use import to test the result (so they test round trip but focus on the export).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test export and import of GeoPackage format.