Merged
Conversation
github-actions
bot
added
raster
Merged
wenzeslaus
requested changes
Jun 10, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Thank you, this is helpful in general and extremely helpful for your work.
With couple minor changes, we can merge this any time.
wenzeslaus
reviewed
Jun 11, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Just one detail to get not just a working tests but also a good example test file for the future.
cyliang368
commented
Jun 11, 2024
Co-authored-by: Vaclav Petras <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wenzeslaus
reviewed
Jun 11, 2024
wenzeslaus
approved these changes
Jun 14, 2024
Member
|
CI successful on mirrored PR here: cyliang368#3, can be merged overriding the status checks requirements. @wenzeslaus |
cyliang368
added a commit
to cyliang368/grass
that referenced
this pull request
Jun 14, 2024
r.texture module has thirteen measure functions, but only five are tested. I added tests for all these functions. They are checked by min, max, mean, variance, and cells instead of just ranges of outputs. Add additional values for macOS test which has slightly different results.
cyliang368
added a commit
to cyliang368/grass
that referenced
this pull request
Jun 14, 2024
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
r.texture module has thirteen measure functions, but only five are tested. I added tests for all these functions. They are checked by min, max, mean, variance, and cells instead of just ranges of outputs. Add additional values for macOS test which has slightly different results.
neteler
pushed a commit
that referenced
this pull request
Oct 8, 2025
r.texture module has thirteen measure functions, but only five are tested. I added tests for all these functions. They are checked by min, max, mean, variance, and cells instead of just ranges of outputs. Add additional values for macOS test which has slightly different results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r.texturemodule has thirteen measure functions, but only five are tested. I added tests for all these functions. They are checked by min, max, mean, variance, and cells instead of just ranges of outputs.