g.setproj: fix uninitialized variable issues in get_stp.c#3777
Merged
wenzeslaus merged 1 commit intoOSGeo:mainfrom Jun 6, 2024
Merged
g.setproj: fix uninitialized variable issues in get_stp.c#3777wenzeslaus merged 1 commit intoOSGeo:mainfrom
wenzeslaus merged 1 commit intoOSGeo:mainfrom
Conversation
wenzeslaus
approved these changes
Jun 6, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
This looks good. Congratulations on your first contribution to this repository!
Member
|
The code is disabled, so the compilers don't see the issues (but cppcheck does), but we clearly have the code in the code base, so it's better when it is fixed. It might be a candidate for removal, though. |
neteler
changed the title
Member
|
Cppcheck is quite fun for that, and it is also what can slow it down. It runs a pass on many combinations of conditional preprocessor defines in order to achieve highest code coverage. That same feature can also make it slower in some cases. |
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
Fixes uninitialized variables reported by Cppcheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes uninitialized variable issues in
general/g.setproj/get_stp.c.Changes Made
Initialized
reccnt:reccntwas used without being initialized.reccntto0at its declaration.Initialized
STabbr_prev:STabbr_prevwas used without being initialized.STabbr_prevto an empty string at its declaration.