r.horizon: always include distance output in JSON output#3768
Merged
petrasovaa merged 2 commits intoOSGeo:mainfrom Jun 7, 2024
Merged
r.horizon: always include distance output in JSON output#3768petrasovaa merged 2 commits intoOSGeo:mainfrom
petrasovaa merged 2 commits intoOSGeo:mainfrom
Conversation
github-actions
bot
added
raster
echoix
previously approved these changes
Jun 4, 2024
wenzeslaus
requested changes
Jun 5, 2024
wenzeslaus
approved these changes
Jun 7, 2024
46 tasks
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Jun 17, 2024
Given the [discussion](OSGeo#3744 (comment)) about what should be part of JSON output, I changed the behavior to include the distance whether or not the -l flag is used. There is no computational reason not to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the discussion about what should be part of JSON output, I changed the behavior to include the distance whether or not the -l flag is used. There is no computational reason not to.