Skip to content

Comments

v.in.ogr: rename option location to project#3576

Merged
petrasovaa merged 7 commits intoOSGeo:mainfrom
petrasovaa:v.in.ogr-rename-project
Apr 11, 2024
Merged

v.in.ogr: rename option location to project#3576
petrasovaa merged 7 commits intoOSGeo:mainfrom
petrasovaa:v.in.ogr-rename-project

Conversation

@petrasovaa
Copy link
Contributor

@petrasovaa petrasovaa commented Apr 9, 2024

Includes changes in user visible strings in v.in.ogr and v.import.

@petrasovaa petrasovaa added this to the 8.4.0 milestone Apr 9, 2024
@petrasovaa petrasovaa requested a review from veroandreo April 9, 2024 18:47
@petrasovaa petrasovaa self-assigned this Apr 9, 2024
@github-actions github-actions bot added vector Related to vector data processing Python Related code is in Python C Related code is in C HTML Related code is in HTML libraries module docs labels Apr 9, 2024
@petrasovaa petrasovaa mentioned this pull request Apr 9, 2024
Open
6 tasks
nilason
nilason previously approved these changes Apr 9, 2024
View reviewed changes
@petrasovaa petrasovaa enabled auto-merge (squash) April 9, 2024 21:20
veroandreo
veroandreo reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@veroandreo veroandreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider editing at least those messages/sentences that include projection and project... Sounds repetitive and IMO, reference system or CRS is more appropriate. What do you think?

@nilason
Copy link
Contributor

nilason commented Apr 9, 2024

I'd consider editing at least those messages/sentences that include projection and project... Sounds repetitive and IMO, reference system or CRS is more appropriate. What do you think?

You’re right, but perhaps an issue for another PR…?

@veroandreo veroandreo mentioned this pull request Apr 9, 2024
Merged
@petrasovaa
Copy link
Contributor Author

petrasovaa commented Apr 10, 2024

I'd consider editing at least those messages/sentences that include projection and project... Sounds repetitive and IMO, reference system or CRS is more appropriate. What do you think?

You’re right, but perhaps an issue for another PR…?

I mostly agree, and I tried to do it in several places in manual pages, but I admit I soon got tired of it. Also I was unsure whether CRS is well known, so I tried using "coordinate reference system (CRS)" which is kind of long.

github-actions[bot]
github-actions bot reviewed Apr 10, 2024
View reviewed changes
@petrasovaa petrasovaa requested a review from veroandreo April 10, 2024 15:56
veroandreo
veroandreo previously approved these changes Apr 10, 2024
View reviewed changes
@petrasovaa @veroandreo
Update vector/v.in.ogr/proj.c
1821fd2 
Co-authored-by: Veronica Andreo <[email protected]>
@petrasovaa petrasovaa requested a review from veroandreo April 10, 2024 20:50
github-actions[bot]
github-actions bot reviewed Apr 10, 2024
View reviewed changes
@petrasovaa petrasovaa merged commit 324ef27 into OSGeo:main Apr 11, 2024
@petrasovaa petrasovaa deleted the v.in.ogr-rename-project branch April 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@veroandreo veroandreo veroandreo approved these changes

@nilason nilason nilason left review comments

Assignees

@petrasovaa petrasovaa

Labels

C Related code is in C docs HTML Related code is in HTML libraries module Python Related code is in Python vector Related to vector data processing

Projects

Rename location to project in GRASS GIS
Status: Done

Milestone

8.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@petrasovaa @nilason @veroandreo