r.in.gdal: rename option location to project#3575
Merged
petrasovaa merged 3 commits intoOSGeo:mainfrom Apr 9, 2024
Merged
Conversation
github-actions
bot
added
raster
nilason
previously approved these changes
Apr 9, 2024
nilason
approved these changes
Apr 9, 2024
veroandreo
reviewed
Apr 9, 2024
Contributor
veroandreo
left a comment
veroandreo
left a comment
There was a problem hiding this comment.
It was merged while I was reviewing... I have the same comment than in #3576, the use of projection and project in the same sentence sounds odd, CRS is more general than projection for that matter
| parm.target->description = _("Name of location to create or to read " | ||
| parm.target->label = _("Name of GCPs target project (location)"); | ||
| parm.target->description = _("Name of project to create or to read " | ||
| "projection from for GCPs transformation"); |
Contributor
There was a problem hiding this comment.
Suggested change
| "projection from for GCPs transformation"); | |
| "CRS from for GCPs transformation"); |
Comment on lines
+217
to
+219
| _("Override projection check (use current project's projection)"); | ||
| flag_o->description = | ||
| _("Assume that the dataset has same projection as the current project"); |
Contributor
There was a problem hiding this comment.
Suggested change
| _("Override projection check (use current project's projection)"); | |
| flag_o->description = | |
| _("Assume that the dataset has same projection as the current project"); | |
| _("Override projection check (use current project's CRS)"); | |
| flag_o->description = | |
| _("Assume that the dataset has same CRS as the current project"); |
| @@ -979,7 +979,7 @@ int main(int argc, char *argv[]) | |||
| &proj_units, hSRS, 0) == 1) { | |||
| G_warning( | |||
| _("Unable to convert input map projection to GRASS " | |||
Contributor
There was a problem hiding this comment.
Suggested change
| _("Unable to convert input map projection to GRASS " | |
| _("Unable to convert input map CRS to GRASS " |
| if ((out_proj_info = G_get_projinfo()) == NULL) | ||
| G_fatal_error( | ||
| _("Unable to get projection info of target location")); | ||
| G_fatal_error(_("Unable to get projection info of target project")); |
Contributor
There was a problem hiding this comment.
Suggested change
| G_fatal_error(_("Unable to get projection info of target project")); | |
| G_fatal_error(_("Unable to get CRS info of target project")); |
| if ((out_unit_info = G_get_projunits()) == NULL) | ||
| G_fatal_error( | ||
| _("Unable to get projection units of target location")); | ||
| _("Unable to get projection units of target project")); |
Contributor
There was a problem hiding this comment.
Suggested change
| _("Unable to get projection units of target project")); | |
| _("Unable to get CRS units of target project")); |
| @@ -197,13 +197,13 @@ void check_projection(struct Cell_head *cellhd, GDALDatasetH hDS, char *outloc, | |||
| int i_value; | |||
|
|
|||
| strcpy(error_msg, _("Projection of dataset does not" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| strcpy(error_msg, _("Projection of dataset does not" | |
| strcpy(error_msg, _("Dataset CRS does not" |
| @@ -322,10 +322,10 @@ void check_projection(struct Cell_head *cellhd, GDALDatasetH hDS, char *outloc, | |||
| strcat(error_msg, _("\nIn case of no significant differences " | |||
| "in the projection definitions," | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "in the projection definitions," | |
| "in the CRS definitions," |
| " use the -o flag to ignore them and use" | ||
| " current location definition.\n")); | ||
| " current project definition.\n")); | ||
| strcat(error_msg, _("Consider generating a new location from " |
Contributor
There was a problem hiding this comment.
Suggested change
| strcat(error_msg, _("Consider generating a new location from " | |
| strcat(error_msg, _("Consider generating a new project from " |
| else | ||
| msg_fn = G_verbose_message; | ||
| msg_fn(_("Projection of input dataset and current location " | ||
| msg_fn(_("Projection of input dataset and current project " |
Contributor
There was a problem hiding this comment.
Suggested change
| msg_fn(_("Projection of input dataset and current project " | |
| msg_fn(_("CRS of input dataset and current project " |
Comment on lines
+109
to
+110
| # % label: Override projection check (use current project's projection) | ||
| # % description: Assume that the dataset has the same projection as the current project |
Contributor
There was a problem hiding this comment.
Suggested change
| # % label: Override projection check (use current project's projection) | |
| # % description: Assume that the dataset has the same projection as the current project | |
| # % label: Override projection check (use current project's CRS) | |
| # % description: Assume that the dataset has the same coordinate reference system (CRS) as the current project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes in user visible strings in r.in.gdal and r.import.