r.in.pdal: use NoFileWriter class for PDAL > 2.7.0 (fixes #3552)#3567
Merged
marisn merged 2 commits intoOSGeo:mainfrom Apr 7, 2024
Merged
r.in.pdal: use NoFileWriter class for PDAL > 2.7.0 (fixes #3552)#3567marisn merged 2 commits intoOSGeo:mainfrom
marisn merged 2 commits intoOSGeo:mainfrom
Conversation
Starting from PDAL 2.7.0 filename is mandatory for Writer class, but there is a NoFileWriter class that maintains old behaviour. PDAL/PDAL#4342
github-actions
bot
added
raster
marisn
changed the title
nilason
requested changes
Apr 7, 2024
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Looks good to me, only one minor suggestion.
Co-authored-by: Nicklas Larsson <[email protected]>
Member
marisn
added a commit
that referenced
this pull request
Apr 14, 2024
Starting from PDAL 2.7.0 filename is mandatory for Writer class, but there is a NoFileWriter class that maintains old behavior. PDAL/PDAL#4342 --------- Co-authored-by: Nicklas Larsson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from PDAL 2.7.0 filename is mandatory for Writer class, but there is a NoFileWriter class that maintains old behaviour. PDAL/PDAL#4342