r.horizon: get rid of global variables and other refactoring#3346
Merged
petrasovaa merged 17 commits intoOSGeo:mainfrom Mar 22, 2024
Merged
r.horizon: get rid of global variables and other refactoring#3346petrasovaa merged 17 commits intoOSGeo:mainfrom
petrasovaa merged 17 commits intoOSGeo:mainfrom
Conversation
Member
|
Does this PR need to be updated following the recent changes in r.horizon? Yes, but they are not all merged yet. |
Member
|
@petrasovaa I didn't see your reply last week as you directly edited my comment instead of replying. |
nilason
requested changes
Feb 20, 2024
Contributor
nilason
left a comment
There was a problem hiding this comment.
I applaud this initiative. Could/should be done on most other modules.
Briefly find a few minor issues, commented in line.
Contributor
Author
Thank you, I applaud you reviewing this! |
nilason
previously approved these changes
Feb 21, 2024
echoix
approved these changes
Mar 21, 2024
Member
echoix
left a comment
There was a problem hiding this comment.
Looks good now, no new comments to address, launched a new round of CI to make sure it still works, but other than that, it seems ready to merge.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored r.horizon to make it possible to extend it in the future (e.g. multiple coordinates, parallelization, etc.), including
I tried not do any changes that could impact results, e.g. there is still some discrepancy in how maxlength is computed for the modes.