g.gui.gmodeler: fix relationship with history pane#3337
Merged
pesekon2 merged 2 commits intoOSGeo:mainfrom Jan 22, 2024
Merged
Conversation
missing giface was causing the entire gmodeler to crash
pesekon2
added
bug
lindakarlovska
approved these changes
Jan 7, 2024
Contributor
lindakarlovska
left a comment
lindakarlovska
left a comment
There was a problem hiding this comment.
@pesekon2 Thanks for fixing it! I have checked other GConsole inits and the giface misses also in gui/wxpython/gui_core/goutput.py:755: self.gconsole = GConsole(guiparent=self). Just the GConsoleFrame for testing purposes. I will open a different PR for it.
I think this PR is ready to be merged..
lindakarlovska
approved these changes
Jan 18, 2024
…relationship_with_history_pane
landam
approved these changes
Jan 22, 2024
pesekon2
deleted the
g_gui_gmodeler_fix_relationship_with_history_pane
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missing giface was causing the entire gmodeler to crash. Fixes #3336.