r.horizon: fix computation in test_low_res()#3298
Merged
petrasovaa merged 2 commits intoOSGeo:mainfrom Jan 5, 2024
Merged
Conversation
petrasovaa
added
bug
wenzeslaus
approved these changes
Jan 5, 2024
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
"One of these things is not like the others."
petrasovaa
added a commit
that referenced
this pull request
Jan 5, 2024
petrasovaa
added a commit
to petrasovaa/grass
that referenced
this pull request
Jan 8, 2024
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a potential error in test_low_res() function, that looks like a copy and paste error, see the variables used in the code above the fix. I don't really understand how that impacts results, the tests seem not affected.