wxGUI/lmgr: fix unfocused Layers pane wx.ListCtrl widget row background color#3264
Merged
tmszi merged 1 commit intoOSGeo:mainfrom Nov 27, 2023
Conversation
…nd color On the wxMac.
tmszi
added
bug
nilason
approved these changes
Nov 27, 2023
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
tmszi
deleted the
wxgui-fix-unfocused-layers-pane-listctrl-widget-row-bg-color
branch
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Nov 27, 2023
…nd color (OSGeo#3264) On the wxMac.
Contributor
|
Would it make sense to remove that gradient altogether for all platforms? Simpler, consistent look may be better, no? |
Member
Author
Formally I agree with you, but the reason I decided not to disable the gradient row color on other OS platforms is that on wxGTK with the default Adwaita GTK+ theme, the background color of the selected layer row blended with the color of the checkbox widget: Disabled gradient color:
Enabled gradient color:
|
Contributor
|
Thanks, I see, I think it is OK either way, but let's keep it then. |
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
…nd color (OSGeo#3264) On the wxMac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3263.