r.in.aster: removed dependency on arch for OSX and added support for ASTER L1T data products#3258
Merged
nilason merged 10 commits intoOSGeo:mainfrom Dec 1, 2023
Merged
r.in.aster: removed dependency on arch for OSX and added support for ASTER L1T data products#3258nilason merged 10 commits intoOSGeo:mainfrom
nilason merged 10 commits intoOSGeo:mainfrom
Conversation
neteler
changed the title
neteler
added
enhancement
nilason
reviewed
Nov 23, 2023
afrigeri
changed the title
nilason
reviewed
Nov 24, 2023
nilason
reviewed
Nov 24, 2023
nilason
requested changes
Nov 24, 2023
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
I added some more suggestions.
You can also delete line 55 ´import platform`, as it is no longer needed.
You will need to run the Python module Black (preferable version 23.1.0) on the py file as there are some formatting issues that need to be corrected (see https://github.com/OSGeo/grass/blob/main/doc/development/submitting/python.md#automation).
agreed! Co-authored-by: Nicklas Larsson <[email protected]>
nilason
approved these changes
Nov 30, 2023
Contributor
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Looks good to me and simple local test (on Mac) succeeded.
Contributor
|
@afrigeri Thank you for your contribution! |
Contributor
Author
Yay! |
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
In addition, removed architecture dependent code for Mac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds to r.in.aster support for:
updated code and manual.
The code expects 15 bands, while The L1T dataset does not include the aft-looking VNIR band 3 (3b), so 3b is the copy of 3n. Future improvements shall consider this aspect specific to L1T.
best,
Alessandro