WIP: init: Parse more version of library version with --config#323
Closed
wenzeslaus wants to merge 1 commit intoOSGeo:mainfrom
Closed
WIP: init: Parse more version of library version with --config#323wenzeslaus wants to merge 1 commit intoOSGeo:mainfrom
wenzeslaus wants to merge 1 commit intoOSGeo:mainfrom
Conversation
Try to parse more version format and places with --congfig revision (libgis version). Print a message when not found or the format was not recognized. Fails with traceback when format was recognized, but not parsed correctly.
wenzeslaus
changed the title
Contributor
|
Note that GIS_H_VERSION is currently not really usable, because it no longer contains the svn revision number of the latest change to gis.h. |
Member
Member
|
Can this be closed? |
neteler
added
enhancement
Member
Author
|
Closing. A completely different approach is now used to define and get revisions/versions, perhaps even the need for greater robustness is not as big as it was with the old system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to parse more version format and places with --config revision (libgis version).
Print a message when not found or the format was not recognized.
Fails with traceback when format was recognized, but not parsed correctly.
Fixes https://trac.osgeo.org/grass/ticket/4001. Note that since bfdb74d, it does not fail if you ask for something which does not need the files and the files are not there, so assuming the dev files are all or nothing, it gives a proper message if you don't have the development part/package.