i.atcorr: add AVIRIS support#3229
Conversation
AVIRIS bands description
|
@YannChemin The ClangFormat check is failing, the code need to be formatted with ClangFormat 15. See https://github.com/OSGeo/grass/blob/main/doc/development/submitting/submitting_c.md#source-code-formatting, I recommend using pre-commit for doing this https://github.com/OSGeo/grass/blob/main/doc/development/submitting/submitting.md#use-pre-commit. |
Hi how to run it again on already committed code? |
|
nilason
left a comment
nilason
left a comment
There was a problem hiding this comment.
Glad you sorted out the clang format issue. I have noted two minor suggestions.
imagery/i.atcorr/altitude.cpp
Outdated
| cin >> original_xpp; | ||
| cin.ignore(numeric_limits<int>::max(), '\n'); /* ignore comments */ | ||
| original_xpp = -original_xpp; | ||
| printf("Original Alt: XPS = %.2f\t XPP = %.2f\n", original_xps, |
There was a problem hiding this comment.
Please consider using G_message() (see https://github.com/OSGeo/grass/blob/main/doc/development/submitting/submitting_c.md#messages).
There was a problem hiding this comment.
There is a G_Debug() maybe?
There was a problem hiding this comment.
Yes, using G_debug() seems perhaps even more appropriate in this case
(https://grass.osgeo.org/programming8/debug_8c.html#af8982bd66c95e3d8d2773ed956c20733).
There was a problem hiding this comment.
Hi what do I do now?
imagery/i.atcorr/iwave.cpp
Outdated
| cin >> iwave; | ||
| cin.ignore(numeric_limits<int>::max(), '\n'); | ||
|
|
||
| printf("iwave = %d\n", iwave); |
There was a problem hiding this comment.
Ditto, please consider using G_message().
remove temoprary print()
remove temporary print()
* Add AVIRIS * Rename aviris.csv to AVIRIS.csv * Update iwave.h * Update iwave.cpp * Update i.atcorr.html * Update i.atcorr.html AVIRIS bands description * Update geomcond.h * Update geomcond.cpp * Add files via upload * pre-commit run --all * Update altitude.cpp remove temoprary print() * Update iwave.cpp remove temporary print()
3 participants
AVIRIS is a plane flying about 20Km high, the 6S configuration file should have three information after the sensor height, in three different lines:
If you do not have this information, please use -1.0
Example
+++++++
31
01 16 23.725 -138.90 28.90
1
2
18
-0.6
-20.56
-1.0
-1.0
-1.0
367