g.region: Fix the flat flag by HuidaeCho · Pull Request #3216 · OSGeo/grass

HuidaeCho · 2023-10-23T14:23:32Z

This PR prints projection= and zone= in the same one line for the flat -f flag.

Before:

$ g.region -pgf
projection=3
zone=0
n=37.0625 s=31.375 w=-109.0625 e=-103 nsres=0.03125 ewres=0.03125 rows=182 cols=194 cells=35308

After:

$ g.region -pgf
projection=3 zone=0 n=37.0625 s=31.375 w=-109.0625 e=-103 nsres=0.03125 ewres=0.03125 rows=182 cols=194 cells=35308

HuidaeCho · 2023-10-23T14:28:03Z

Maybe later for a new release in a separate PR, it would be better to imply -g when -f is used. Currently, both -g and -f are needed and -f without -g has no effect (surprise!). Just using -f should replace -gf IMO, UNLESS -f flattening is also used for other formats.

Or it just needs a better description because other flags are also accumulative as well?

petrasovaa · 2023-10-24T18:29:43Z

There are print flags that add information (-l, -e, -c, -n, -3, -b). I don't think all of them are printed in flat format on 1 line with this PR yet.

I agree the -f flag should stand on its own in the same way you don't have to use -g flag together with -p flag. Ultimately we could introduce some kind of format method to include json format and get rid of all these flags?

There are some flags that don't seem to be behaving consistently, e.g. -t (no key printed), -w (always key=value format) and maybe some others.

wenzeslaus

+1 for making flat really one line. This strangeness was there for a while and it prevents use in shell scripting without addition of a grep filter.

A test for -gf and -f would be nice, e.g., testing that -f really yields one line only which was apparently missing. There is already general/g.region/testsuite/ so it should be relatively easy to add a new test.

wenzeslaus · 2023-11-07T14:42:46Z

There are print flags that add information (-l, -e, -c, -n, -3, -b). I don't think all of them are printed in flat format on 1 line with this PR yet.

I think that falls into the general revision of all output formats below.

I agree the -f flag should stand on its own in the same way you don't have to use -g flag together with -p flag.

I also expect that. -g usually means "key=value" line by line in other tools and there are no modifications to the format.

Ultimately we could introduce some kind of format method to include json format and get rid of all these flags?

That would be ideal.

HuidaeCho · 2024-01-23T13:27:26Z

There are print flags that add information (-l, -e, -c, -n, -3, -b). I don't think all of them are printed in flat format on 1 line with this PR yet.

Done.

HuidaeCho · 2024-01-23T13:28:56Z

There are print flags that add information (-l, -e, -c, -n, -3, -b). I don't think all of them are printed in flat format on 1 line with this PR yet.

I think that falls into the general revision of all output formats below.

I agree the -f flag should stand on its own in the same way you don't have to use -g flag together with -p flag.

I also expect that. -g usually means "key=value" line by line in other tools and there are no modifications to the format.

Ultimately we could introduce some kind of format method to include json format and get rid of all these flags?

That would be ideal.

Agreed, but I think that's for another PR.

HuidaeCho · 2024-01-23T13:31:17Z

There are some flags that don't seem to be behaving consistently, e.g. -t (no key printed), -w (always key=value format) and maybe some others.

Yep, GMT doesn't have a key. bbox= (already used with -w...) might be good? Or when -p prints the same info already, both -t and -w should be exclusive to -f? I think both -t and -w are meant to be standalone.

petrasovaa

I tested it and added a test for the f flag.

I tested the standalone -f flag, here is the code for it, but probably you are right this should be a separate PR.

diff --git a/general/g.region/main.c b/general/g.region/main.c
index 06c33a2e8c..33ad06f383 100644
--- a/general/g.region/main.c
+++ b/general/g.region/main.c
@@ -361,7 +361,7 @@ int main(int argc, char *argv[])
     G_option_required(
         flag.dflt, flag.savedefault, flag.print, flag.lprint, flag.eprint,
         flag.center, flag.gmt_style, flag.wms_style, flag.dist_res, flag.nangle,
-        flag.z, flag.bbox, flag.gprint, flag.res_set, flag.noupdate,
+        flag.z, flag.bbox, flag.gprint, flag.flprint, flag.res_set, flag.noupdate,
         parm.region, parm.raster, parm.raster3d, parm.vect, parm.north,
         parm.south, parm.east, parm.west, parm.top, parm.bottom, parm.rows,
         parm.cols, parm.res, parm.res3, parm.nsres, parm.ewres, parm.tbres,
@@ -371,7 +371,6 @@ int main(int argc, char *argv[])
                       flag.eprint, flag.center, flag.gmt_style, flag.wms_style,
                       flag.dist_res, flag.nangle, flag.z, flag.bbox,
                       flag.gprint, parm.save, NULL);
-    G_option_requires(flag.flprint, flag.gprint, NULL);
 
     if (G_parser(argc, argv))
         exit(EXIT_FAILURE);
@@ -383,7 +382,7 @@ int main(int argc, char *argv[])
     if (flag.print->answer)
         print_flag |= PRINT_REG;
 
-    if (flag.gprint->answer)
+    if (flag.gprint->answer || flat_flag)
         print_flag |= PRINT_SH;
 
     if (flag.lprint->answer)

echoix

I read the changes and they make sense for what it says it does ;)

echoix · 2024-02-08T05:47:29Z

Created issues to not forget about the other points, so this PR should be good to merge, it was already reviewed and approved, and I took another look at it.

* g.region: Fix the flat flag * Revert datum: and ellipsoid: * Flatten other outputs * Flat (-f) requires shell (-g) print * Flatten WMS output * add test * fix formatting --------- Co-authored-by: Anna Petrasova <[email protected]> Co-authored-by: Edouard Choinière <[email protected]>

HuidaeCho added 2 commits October 23, 2023 08:18

g.region: Fix the flat flag

43101d7

Revert datum: and ellipsoid:

1792a6e

HuidaeCho added the bug Something isn't working label Oct 23, 2023

neteler added this to the 8.4.0 milestone Nov 4, 2023

wenzeslaus reviewed Nov 7, 2023

View reviewed changes

landam assigned HuidaeCho Nov 19, 2023

Flatten other outputs

0a949d3

github-actions bot added C Related code is in C module general labels Jan 23, 2024

Flat (-f) requires shell (-g) print

acb2da5

HuidaeCho and others added 2 commits January 23, 2024 06:36

Flatten WMS output

fadc691

add test

a0650ab

github-actions bot added the Python Related code is in Python label Jan 31, 2024

fix formatting

c6f74b1

petrasovaa approved these changes Jan 31, 2024

View reviewed changes

This was referenced Feb 8, 2024

[Feat] g.region: implement standalone flat flag in g.region #3409

Open

g.region: revision of output formats #3410

Open

echoix approved these changes Feb 8, 2024

View reviewed changes

Merge branch 'main' into g_region_flat

44e62f7

HuidaeCho merged commit 4ea78a7 into OSGeo:main Feb 9, 2024

HuidaeCho deleted the g_region_flat branch February 9, 2024 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

g.region: Fix the flat flag#3216

g.region: Fix the flat flag#3216
HuidaeCho merged 8 commits intoOSGeo:mainfrom
HuidaeCho:g_region_flat

HuidaeCho commented Oct 23, 2023

Uh oh!

HuidaeCho commented Oct 23, 2023 •

edited

Loading

Uh oh!

petrasovaa commented Oct 24, 2023 •

edited by wenzeslaus

Loading

Uh oh!

wenzeslaus left a comment

Uh oh!

wenzeslaus commented Nov 7, 2023

Uh oh!

HuidaeCho commented Jan 23, 2024

Uh oh!

HuidaeCho commented Jan 23, 2024

Uh oh!

HuidaeCho commented Jan 23, 2024 •

edited

Loading

Uh oh!

petrasovaa left a comment •

edited by echoix

Loading

Uh oh!

echoix left a comment

Uh oh!

echoix commented Feb 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Comments

Conversation

HuidaeCho commented Oct 23, 2023

Uh oh!

HuidaeCho commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrasovaa commented Oct 24, 2023 • edited by wenzeslaus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wenzeslaus left a comment

Choose a reason for hiding this comment

Uh oh!

wenzeslaus commented Nov 7, 2023

Uh oh!

HuidaeCho commented Jan 23, 2024

Uh oh!

HuidaeCho commented Jan 23, 2024

Uh oh!

HuidaeCho commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrasovaa left a comment • edited by echoix Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

echoix left a comment

Choose a reason for hiding this comment

Uh oh!

echoix commented Feb 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HuidaeCho commented Oct 23, 2023 •

edited

Loading

petrasovaa commented Oct 24, 2023 •

edited by wenzeslaus

Loading

HuidaeCho commented Jan 23, 2024 •

edited

Loading

petrasovaa left a comment •

edited by echoix

Loading