grass.script: ensure memmap content is flushed before writing to a raster#3206
Merged
petrasovaa merged 1 commit intoOSGeo:mainfrom Oct 24, 2023
Merged
grass.script: ensure memmap content is flushed before writing to a raster#3206petrasovaa merged 1 commit intoOSGeo:mainfrom
petrasovaa merged 1 commit intoOSGeo:mainfrom
Conversation
petrasovaa
added
bug
wenzeslaus
approved these changes
Oct 19, 2023
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Thank you! This fits with the NumPy documentation.
For the tests, please just update your branch from main.
petrasovaa
force-pushed
the
array-flush
branch
from
3749bd1 to
957b0dc
Compare
Member
|
May this PR be merged and backported, to become part of 8.3.1? |
petrasovaa
changed the title
petrasovaa
added a commit
that referenced
this pull request
Oct 24, 2023
landam
pushed a commit
to landam/grass
that referenced
this pull request
Oct 25, 2023
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy.memap needs to be flushed so that grass.script.array.write() method writes correct content to a raster. The problem was found when running on an HPC with fairly large array that was being modified and then written to raster - only portion of it was being written correctly, the rest was empty.
May be worth including in 8.3.1 release.