CI: Create workflow to update configure, config.guess and config.sub #3200
CI: Create workflow to update configure, config.guess and config.sub #3200nilason merged 10 commits intoOSGeo:mainfrom
Conversation
For updating configure files
|
I wanted at least once a month, so if your workflow log retention is 90 days, we could at least see more than one past run. |
|
Only |
When does this file get updated then?
It's a starting point. I copied the old doc from https://github.com/OSGeo/grass/blob/releasebranch_7_8/doc/howto_release.md#update-of-configure-base-files Now we can tune what we want exactly, since it's easy to see what is done. |
This is a great enhancement! And skipping the autoconf part, it will be even more simple. |
If you run I realise that it shouldn't be |
|
If you run with an unpatched version of autoconf 2.69 (which you should), then there will be no changes. Several distributions do have patched versions. |
If you could manage to build a "clean" autoconf version 2.69 on CI, run autoconf with that version and if However I support the very simple and uncontroversial approach to create a PR with updated config.guess and config.sub. |
|
Besides the minor (cleaning up) issues noted in the comments above, this looks fine to me! |
|
I saw the comments yesterday. I also have in my fork some playing around with the clang-format. It makes no sense that it takes 22 min+. The action used calls a docker container mapped to a single file, for every file in the entrypoint.sh. I used an action that logs the cpu/memory usage throughout a workflow run to visualize that it was really one thread, and mostly system cpu time. I quickly tested out using another clang-format action, to be sure to see what gains we could have before trying to file some details at the action, and it was roughly 27 seconds out of 47seconds. I was waiting for some input on my previous PRs to continue working on it. |
|
I think it is at what you wanted. Since it doesn't check that it builds, if ever the run doesn't fail, I added a note in the PR's message to go check the logs if the two files were deleted and not replaced. |
This seems to work fine and it is all this need to do. Thank you! Just please run the file through pre-commit and correct the warnings/errors. |
|
I never used pre-commit before, but I tried something. The remaining yamllint warning is with the comment with the action ref, I don't know how to fix it, since for renovate to pick it up it should be on the same line? |
|
I saw one of your PRs that added an extra space, I think that does it! |
nilason
left a comment
There was a problem hiding this comment.
Thanks for fixing the linting issues and for a very useful contribution!
|
Ready to merge? |
From my point of view, yes. Waiting for approval from @wenzeslaus as he previously had some issues. |
|
There's been no objection for a week! |
Check monthly if 'config.guess' and 'config.sub' are updated and create a pull request with updates if that is the case.
For #3161 (comment)
I tested it out on my branch (see the PR created echoix#2), and it seems the folder
autom4te.cacheis not in the.gitignore.See the workflow run logs at
https://github.com/echoix/grass/actions/runs/6419301021/job/17428853123