Skip to content

Comments

wxGUI/preferences: fix setting command output font#3187

Merged
tmszi merged 1 commit intoOSGeo:mainfrom
tmszi:wxgui-preferences-fix-changing-font-setts-for-output-console
Sep 26, 2023
Merged

wxGUI/preferences: fix setting command output font#3187
tmszi merged 1 commit intoOSGeo:mainfrom
tmszi:wxgui-preferences-fix-changing-font-setts-for-output-console

Conversation

@tmszi
Copy link
Member

@tmszi tmszi commented Sep 24, 2023

Describe the bug
Setting wxGUI command output font fails and prints an error message.

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI g.gui
  2. Open GUI settings dialog from main toolbar
  3. On the GUI settings dialog switch to Appearance page (tab)
  4. Try to change command output font (Font settings), hit Set font button widget
  5. See error
Traceback (most recent call last):
  File
"/usr/lib64/grass84/gui/wxpython/gui_core/preferences.py",
line 2042, in OnSetOutputFont

outfont = wx.Font(
TypeError
:
Font(): arguments did not match any overloaded call:
  overload 1: too many arguments
  overload 2: argument 1 has unexpected type 'float'
  overload 3: argument 1 has unexpected type 'float'
  overload 4: argument 1 has unexpected type 'float'
  overload 5: argument 1 has unexpected type 'float'
  overload 6: argument 1 has unexpected type 'float'
  overload 7: argument 1 has unexpected type 'float'

Expected behavior
Setting wxGUI command output font should work without prints an error message.

System description:

  • Operating System: GNU/Linux
  • GRASS GIS version: all
GRASS nc_spm_08_grass7/landsat:~ > python3 -c "import sys, wx; print(sys.version); print(wx.version())"
3.10.13 (main, Sep 16 2023, 22:24:59) [GCC 12.3.1 20230526]
4.2.0 gtk3 (phoenix) wxWidgets 3.2.2.1

@tmszi tmszi added bug Something isn't working GUI wxGUI related backport to 8.3 labels Sep 24, 2023
@tmszi tmszi added this to the 8.3.1 milestone Sep 24, 2023
@tmszi tmszi merged commit e34e16d into OSGeo:main Sep 26, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Sep 26, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Sep 26, 2023
@tmszi tmszi deleted the wxgui-preferences-fix-changing-font-setts-for-output-console branch September 26, 2023 11:52
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working GUI wxGUI related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants