Skip to content

Comments

docs: add note on updating config.guess and config.sub files#3161

Closed
nilason wants to merge 1 commit intoOSGeo:mainfrom
nilason:docs_release_upd_configure
Closed

docs: add note on updating config.guess and config.sub files#3161
nilason wants to merge 1 commit intoOSGeo:mainfrom
nilason:docs_release_upd_configure

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Sep 15, 2023

Just happened to see the config.guess and config.sub files haven't been updated in a year and a half. It's very easy to forget, so I propose to add a note on this to the "how to release" instructions.

@wenzeslaus
Copy link
Member

While I agree the procedure should be somewhere, I'm reluctant to add that to the release procedure. The release procedure is already lengthy, so adding more steps just makes releases harder. There is also no reason to do at the release time and it might be counterproductive if issues arise. Next candidate would be branching procedure (#2963), but the same issues apply there just less severely.

Obviously, a bot update or a scheduled workflow would be nice, but documenting maintenance chores which are done manually is a first step. Maybe we need a document which is sort of a crontab for people where this should go.

@nilason
Copy link
Contributor Author

nilason commented Sep 15, 2023

I'm open to any alternative solution, this came to mind after locking back on the discussion at last update #2225.

@wenzeslaus
Copy link
Member

Maybe doc/development/chores.txt?

@nilason
Copy link
Contributor Author

nilason commented Sep 15, 2023

Maybe doc/development/chores.txt?

Why not markdown file?

I'm not sure what else to add to such a file, but I can create the file and make this PR a draft. From there on we can continue...

@wenzeslaus
Copy link
Member

Sure, I meant md. There is the autoconf update too or not? I'm sure (afraid) there are other things. Like contributor list.

@nilason
Copy link
Contributor Author

nilason commented Sep 15, 2023

Sure, I meant md. There is the autoconf update too or not? I'm sure (afraid) there are other things. Like contributor list.

Let us connect @neteler to this issue. Markus, do you have any thoughts on this?

@neteler
Copy link
Member

neteler commented Sep 17, 2023

Sure, I meant md. There is the autoconf update too or not?

No, there isn't. Just run autoconf. It used to be documented, here from 8.0 notes (they were removed from later versions of the file):

https://github.com/OSGeo/grass/blob/releasebranch_8_0/doc/howto_release.md#update-of-configure-base-files

@wenzeslaus
Copy link
Member

What I meant is that it is needed or it is not?

Anyway, let's keep it out of the release howto which has >500 lines on main.

@neteler
Copy link
Member

neteler commented Sep 18, 2023

What I meant is that it is needed or it is not?

Yes, the update of config.guess and config.sub files is needed from time to time (at least once a year I'd say).

@neteler neteler added this to the 8.4.0 milestone Oct 5, 2023
@neteler
Copy link
Member

neteler commented Oct 5, 2023

Just happened to see the config.guess and config.sub files haven't been updated in a year and a half.

BTW: following https://github.com/OSGeo/grass/blob/releasebranch_7_8/doc/howto_release.md#update-of-configure-base-files locally, the autoconf (2.71) step shows several warnings.

If cronjobs are possible this updating could be best done in the CI and generate a PR.

@nilason
Copy link
Contributor Author

nilason commented Oct 5, 2023

BTW: following https://github.com/OSGeo/grass/blob/releasebranch_7_8/doc/howto_release.md#update-of-configure-base-files locally, the autoconf (2.71) step shows several warnings.

The version number is the key issue there for the warnings.

If cronjobs are possible this updating could be best done in the CI and generate a PR.

That sound like a plan :-)

@nilason
Copy link
Contributor Author

nilason commented Oct 5, 2023

BTW: following https://github.com/OSGeo/grass/blob/releasebranch_7_8/doc/howto_release.md#update-of-configure-base-files locally, the autoconf (2.71) step shows several warnings.

The version number is the key issue there for the warnings.

#3199 aims to address those warnings.

@echoix
Copy link
Member

echoix commented Oct 5, 2023

What are the commands that should be run in a terminal that you would like to have in CI? I could draft a little GitHub workflow for that, that would run like once a month, and possible to trigger to run as wanted (by starting it in the actions tab). It could make a PR with the changes afterwards.

@echoix
Copy link
Member

echoix commented Oct 5, 2023

And any other maintenance tasks could follow the same pattern.

@neteler
Copy link
Member

neteler commented Oct 5, 2023

What are the commands that should be run in a terminal that you would like to have in CI?

I believe these steps:
https://github.com/OSGeo/grass/blob/releasebranch_7_8/doc/howto_release.md#update-of-configure-base-files

Then run twice a year or so.

@echoix
Copy link
Member

echoix commented Oct 5, 2023

I just finished filing the PR. I wanted at least once a month, so if your workflow log retention is 90 days, we could at least see more than one past run.

@nilason
Copy link
Contributor Author

nilason commented Nov 19, 2023

Closing this in favour of #3200.

@nilason nilason closed this Nov 19, 2023
@nilason nilason deleted the docs_release_upd_configure branch May 15, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants