i.ortho.target: Rename location and mapset options to target#3131
Merged
petrasovaa merged 5 commits intoOSGeo:mainfrom Mar 22, 2024
Merged
i.ortho.target: Rename location and mapset options to target#3131petrasovaa merged 5 commits intoOSGeo:mainfrom
petrasovaa merged 5 commits intoOSGeo:mainfrom
Conversation
i.ortho.target has option target_location and mapset_location. This renames them to target_project and target_mapset, so the new names are consistent. While mapsets are in locations (projects), there seems to be no reason for the word location in mapset_location because it is G_OPT_M_MAPSET. This also includes change for g.gui.image2target which uses G_OPT_M_LOCATION with a custom name target_location, now renamed target_project. Both old and new names are consistent with target_project in i.ortho.target.
wenzeslaus
added
enhancement
petrasovaa
requested changes
Mar 12, 2024
Contributor
petrasovaa
left a comment
petrasovaa
left a comment
There was a problem hiding this comment.
The manual pages contain "location" as well.
petrasovaa
reviewed
Mar 12, 2024
petrasovaa
previously approved these changes
Mar 22, 2024
petrasovaa
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i.ortho.target has option target_location and mapset_location. This renames them to target_project and target_mapset, so the new names are consistent. While mapsets are in locations (projects), there seems to be no reason for the word location in mapset_location because it is G_OPT_M_MAPSET.
This also includes change for g.gui.image2target which uses G_OPT_M_LOCATION with a custom name target_location, now renamed target_project. Both old and new names are consistent with target_project in i.ortho.target.