r.sun: fix -Wimplicit-int warnings#3097
Conversation
|
Please, link a PR which is merged. #1405 is closed without merging and this change which comments out code requires at least some explanation. |
For now only comments out relevant parts. Addresses -Wimplicit-int compiler warnings. The warning is treated as an error by Clang 16+ and the compilation fails. This is a partial, manual backport of OSGeo#1405, commit 594c947.
nilason
force-pushed
the
fix_implicit_int_78
branch
from
ab08720 to
664581a
Compare
That PR was created just before the change to "Squash and merge"-only policy, so I cherry picked and pushed each commit in the PR manually (to keep each fix separate). But you're right about the lack of explanation, I incorporated the original commit message with updates:
|
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
Compilation tested fine with gcc version 12.3.1 on Fedora 37.
3 participants
This is a partial, manual backport of #1405.
The warning is treated as an error by Clang 16+ and the compilation fails.
Considering next 7.8 release likely will be the last, this should be a blocker.