d.vect.thematic: Do not show decimal places for ints#3096
d.vect.thematic: Do not show decimal places for ints#3096wenzeslaus merged 2 commits intoOSGeo:mainfrom
Conversation
Number of minimal decimal places is fixed to 2 in the legend generated by d.vect.thematic. This adds logic which changes the number of decimal places to 0 when the column type is integer (DB_C_TYPE_INT). This does not let user decide the number, but it covers more cases and it prepares a way for making it parametrized in the future.
|
This will be a nice update if the module can be made to work with 8.4 |
github-actions
bot
added
C
|
The current CI checks are now running on this and the PR is now set to auto-merge when it passes the requirements. With our new system with required reviews, it needs an approving review from a maintainer. In this new system, users and contributors without write access can help by leaving a reviews for whatever they feel qualified to judge, e.g. after testing the change. |
|
Depending on how it was configured exactly, someone without write access can leave reviews, but they'll be gray instead of green, and won't "count" on the required reviews. However, I'm open to patch this and approve a PR if it is approved by such a person that would be a better reference than me, to unblock those rare cases. |
I think that should be our approach when applicable. We have a lot of skillful users/contributors/testers who can evaluate the functionality, sometimes even the code, so it would be great to have and use their input.
As far as I can tell, that's the only configuration and that makes sense to me. |
Number of minimal decimal places is fixed to 2 in the legend generated by d.vect.thematic. This adds logic which changes the number of decimal places to 0 when the column type is integer (DB_C_TYPE_INT). This does not let user decide the number, but it covers more cases than the current code and it prepares a way for making it parametrized in the future.
6 participants
Number of minimal decimal places is fixed to 2 in the legend generated by d.vect.thematic. This adds logic which changes the number of decimal places to 0 when the column type is integer (DB_C_TYPE_INT).
This does not let user decide the number, but it covers more cases than the current code and it prepares a way for making it parametrized in the future.