d.legend.vect: Initialize title size#3095
Merged
wenzeslaus merged 1 commit intoOSGeo:mainfrom Nov 20, 2023
Merged
Conversation
Later test (line 270) uses title width to compute background size regardless of title presence, but original code initialized title_w only when title was set. This fixes occasional extra wide legend background rectangle. Identified by valgrind as: Conditional jump or move depends on uninitialised value(s).
landam
approved these changes
Nov 19, 2023
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
Later test (line 270) uses title width to compute background size regardless of title presence, but original code initialized title_w only when title was set. This fixes occasional extra wide legend background rectangle. Identified by valgrind as: Conditional jump or move depends on uninitialized value(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Later test (line 270) uses title width to compute background size regardless of title presence, but original code initialized title_w only when title was set.
This fixes occasional extra wide legend background rectangle.
Identified by valgrind as: Conditional jump or move depends on uninitialized value(s).