Skip to content

Comments

wxGUI/dbmgr: fix show attribute table for vector map from another mapset#3081

Merged
tmszi merged 3 commits intoOSGeo:mainfrom
tmszi:wxgui-dbmgr-fix-show-attr-table-from-other-mapset
Jul 19, 2023
Merged

wxGUI/dbmgr: fix show attribute table for vector map from another mapset#3081
tmszi merged 3 commits intoOSGeo:mainfrom
tmszi:wxgui-dbmgr-fix-show-attr-table-from-other-mapset

Conversation

@tmszi
Copy link
Member

@tmszi tmszi commented Jul 12, 2023

Fixes #3078.

@tmszi tmszi added bug Something isn't working GUI wxGUI related backport to 8.3 backport to 7.8 PR needs to be backported to release branch 7.8 labels Jul 12, 2023
@tmszi tmszi added this to the 8.3.1 milestone Jul 12, 2023
@tmszi tmszi requested a review from petrasovaa July 12, 2023 20:35
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI shouldn't be temporarily changing mapsets. The way to do it is to use gs.create_environment and pass that environment to db.connect.

@tmszi
Copy link
Member Author

tmszi commented Jul 14, 2023

GUI shouldn't be temporarily changing mapsets. The way to do it is to use gs.create_environment and pass that environment to db.connect.

Yes you are right, thanks for your explanation.

@tmszi
Copy link
Member Author

tmszi commented Jul 14, 2023

#3086 solve issue #3078.

@tmszi tmszi closed this Jul 14, 2023
@tmszi tmszi deleted the wxgui-dbmgr-fix-show-attr-table-from-other-mapset branch July 14, 2023 21:04
@petrasovaa
Copy link
Contributor

I think this could still be useful if the mapset is created manually without initialization. The only thing I would perhaps modify is relying on vectname to include mapset, using find_file may be a good idea.

@tmszi tmszi restored the wxgui-dbmgr-fix-show-attr-table-from-other-mapset branch July 18, 2023 11:09
@tmszi tmszi reopened this Jul 18, 2023
@tmszi
Copy link
Member Author

tmszi commented Jul 18, 2023

I think this could still be useful if the mapset is created manually without initialization. The only thing I would perhaps modify is relying on vectname to include mapset, using find_file may be a good idea.

Ok, I'm reopening this PR and have incorporated your suggestion.

@tmszi tmszi modified the milestones: 8.3.1, 8.4.0 Jul 18, 2023
@tmszi tmszi removed the backport to 7.8 PR needs to be backported to release branch 7.8 label Jul 18, 2023
@tmszi tmszi requested a review from petrasovaa July 19, 2023 15:09
@tmszi tmszi merged commit 44e87d8 into OSGeo:main Jul 19, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Jul 19, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Jul 19, 2023
@tmszi tmszi deleted the wxgui-dbmgr-fix-show-attr-table-from-other-mapset branch July 19, 2023 16:45
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working GUI wxGUI related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] opening attribute table in empty mapset freezes GUI

2 participants