docker: CI update and simplification#3075
Conversation
|
While the main branch of GRASS GIS is fairly stable, I think it is more expected that it is the latest release rather than the latest state of the code. |
|
Updated workflow to build and push |
|
@wenzeslaus I updated the file according to your suggestion. Do you agree now? |
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
Thanks, looks good to me (but another reviewer is welcome)
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
I appreciate that this is much shorter. The need to understand the many options of docker/metadata-action is unfortunate, but seem like a better alternative to the long custom code.
I'm still unclear about how some of the cases will work out here. I left individual comments for that.
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
With the clarifications and plan for backporting, this makes a lot of sense and seems to fit with the GitHub and docker/metadata-action doc.
|
Great work, I take liberty to merge it and backport now. |
* simplify docker gh workflow (see PR for details)
* simplify docker gh workflow (see PR for details)
* simplify docker gh workflow (see PR for details)
* simplify docker gh workflow (see PR for details)
3 participants
!! Description updated to reflect merged status after discussions!!
This PR simplifies the github workflow for docker build, tag and push.
Due to some tag restructuring and new features of docker/metadata-action it now only uses one job and, depending on the trigger action, creates different tags. It will create four different types of tags:
latestfor latest release (at this time 8.3) and with ubuntu oscurrent-{{ os }}for a still hard-coded branch, here update to releasebranch_8_3, e.gcurrent-ubuntu{{ branch }}-{{ os }}for all configured branches, e.g.releasebranch_8_3-alpine,main-debian{{ tag }}-{{ os }}for all published releases. e.g.8.3.0-alpineThis new naming conforms more with the GRASS GIS naming style of versions. While naming of branches and tags is still the same, it adds
current-{{ os }}and abandons former naming style withlatest-{{ os }}andstable-{{ os }}likelatest-alpineandstable-alpineto avoid confusion. Also content oflatesttag was changed frommainbranch to latest release.The plainlatesttag is still created because it is default fordocker pull osgeo/grass-gisand would be nice to have, although usage of it is not recommended. No strong opinion if it should point tomainbranch orreleasebranch_8_3. Open for discussion. See also OSGeo/grass-website#371As the action was triggered twice for a release,
on: [tags ](tags: ['*.*.*'])was outcommented.Whole thing was tested as can be seen in first commit of this PR on a branch named
docker-workflow-updatewith mmacata remote and dockerhub account. Created and pushed image tags can be seen here on dockerhub.