i.signatures: Add imagery classifier signature management module#3008
i.signatures: Add imagery classifier signature management module#3008marisn merged 17 commits intoOSGeo:mainfrom
Conversation
|
One thing to discuss: how should "type" values be named? At the moment they follow internal naming of signature files (i.gensig -> "sig"; i.gensigset -> "sigset") but it might be hard to get it right for users. An alternative could be naming after consumer ("maxlik" and "smap"). Other issue is that the GUI at the moment can not handle signature file name selection as it requires linking "type" with "copy", "rename" and "remove" to list signatures of selected type. |
I'd prefer to name them as the module that generates them, i.e., i.gensig -> "sig"; i.gensigset -> "sigset", seems more consistent to me. |
|
The sig and sigset are indeed confusing, but the producer modules are named that way as well as the internal files, so using sig and sigset is hopefully less confusion overall. Perhaps the consumer modules need to be really good at documenting what they need. |
Consumer module documentation lists the correct workflow. Also the parser code will not let to pass wrong signature file. This is only an issue for this module as it allows to operate on all of them. |
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
I'm not sure if this should be one tool or multiple tools. This would also determine how the options are named. Similar is g.extension because it can list, add or remove.
Improve documentation and test to match current state
wenzeslaus
changed the title
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
The C part looks good to go.
and short version to pass as a parameter to module
|
If there are no objections, I'll merge. |
Thanks to parser, use of uninitalized variable was not possible, but static code analizers are not aware of it.
…eo#3008) This module allows to manage signature files created by various imagery classification modules such as i.gensig, i.gensigset. The module allows to list, copy, rename and delete signature files. --------- Co-authored-by: Anna Petrasova <[email protected]>
…eo#3008) This module allows to manage signature files created by various imagery classification modules such as i.gensig, i.gensigset. The module allows to list, copy, rename and delete signature files. --------- Co-authored-by: Anna Petrasova <[email protected]>
…eo#3008) This module allows to manage signature files created by various imagery classification modules such as i.gensig, i.gensigset. The module allows to list, copy, rename and delete signature files. --------- Co-authored-by: Anna Petrasova <[email protected]>
5 participants
For the first time of GRASS history this PR tries to introduce a tool capable of managing signature files.