Skip to content

Comments

CI: update github/super-linter docker tag to v4#2782

Merged
neteler merged 3 commits intoOSGeo:mainfrom
neteler:ci_super_linter
Jan 24, 2023
Merged

CI: update github/super-linter docker tag to v4#2782
neteler merged 3 commits intoOSGeo:mainfrom
neteler:ci_super_linter

Conversation

@neteler
Copy link
Member

@neteler neteler commented Jan 23, 2023

Replaces #2778

Selectively update super-linter.yml to GRASS GIS Addons PR OSGeo/grass-addons#847

This PR contains the following updates:

Package Type Update Change
github/super-linter docker major v2.2.2 -> v4

Replaces #2778

Selectively update `super-linter.yml` to GRASS GIS Addons PR OSGeo/grass-addons#847
@neteler neteler added the CI Continuous integration label Jan 23, 2023
@neteler neteler added this to the 8.3.0 milestone Jan 23, 2023
@neteler neteler self-assigned this Jan 23, 2023
@neteler
Copy link
Member Author

neteler commented Jan 23, 2023

In baea7da my attempt to fix

[FATAL] Behavior not supported, please either only include (VALIDATE=true) or exclude (VALIDATE=false) linters, but not both

Co-authored-by: Nicklas Larsson <[email protected]>
@echoix
Copy link
Member

echoix commented Jan 24, 2023

LGTM! (Looks good to me!)

@neteler neteler merged commit 36f4826 into OSGeo:main Jan 24, 2023
@neteler neteler deleted the ci_super_linter branch January 24, 2023 17:43
uses: github/super-linter@v4
env:
# Listed but disabled linters would be nice to have.
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: setting GITHUB_TOKEN was needed for listing each test:

Screenshot

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I assume you have updated this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the markdown files with #2762. The others were apparently good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this upgrade of super-linter (incl. GITHUB_TOKEN), it only looked like:

Screenshot2

which wasn't very informative.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: setting GITHUB_TOKEN was needed for listing each test:

Ah, you meant adding the GITHUB_TOKEN line in the super-linteryml file, right? (I initially thought that you have set the secret somewhere in the GH settings.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See beginning of https://github.com/github/super-linter#how-to-use

NOTE: If you pass the Environment variable GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} in your workflow, then the GitHub Super-Linter will mark the status of each individual linter run in the Checks section of a pull request. Without this you will only see the overall status of the full run. There is no need to set the GitHub Secret as it is automatically set by GitHub, it only needs to be passed to the action.

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* CI: update github/super-linter docker tag to v4

Replaces OSGeo#2778

Selectively update `super-linter.yml` to GRASS GIS Addons PR OSGeo/grass-addons#847

* do not mix VALIDATE=true and VALIDATE=false
* VALIDATE_MD -> VALIDATE_MARKDOWN

Co-authored-by: Nicklas Larsson <[email protected]>
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
* CI: update github/super-linter docker tag to v4

Replaces OSGeo#2778

Selectively update `super-linter.yml` to GRASS GIS Addons PR OSGeo/grass-addons#847

* do not mix VALIDATE=true and VALIDATE=false
* VALIDATE_MD -> VALIDATE_MARKDOWN

Co-authored-by: Nicklas Larsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants