CI: switch to ubuntu-22.04 image to avoid timeout by neteler · Pull Request #2730 · OSGeo/grass

neteler · 2023-01-04T19:27:13Z

Since the older ubuntu-20.04 image based runs commonly time-out, here an attempt with the current ubuntu-22.04 image.

See also: https://github.com/actions/runner-images

Since the older ubuntu-20.04 image based runs commonly time-out, here an attempt with the current ubuntu-22.04 image.

neteler · 2023-01-04T22:39:10Z

Mhh, this triggers unrelated other issues:

gcc  -std=gnu11 -fPIC -Wall -Wno-error=maybe-uninitialized -Werror  -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include   -I/usr/include/gdal -I/usr/include  -DPACKAGE=\""grasslibs"\"     -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -I/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include -DRELDIR=\"lib/ogsf\" -o OBJ.x86_64-pc-linux-gnu/gs2.o -c gs2.c
gs2.c: In function ‘GS_get_distance_alongsurf’:
gs2.c:3296:5: error: ‘gsd_real2surf’ accessing 12 bytes in a region of size 8 [-Werror=stringop-overflow=]
 3296 |     gsd_real2surf(gs, p1);
      |     ^~~~~~~~~~~~~~~~~~~~~
gs2.c:3296:5: note: referencing argument 2 of type ‘float *’
In file included from /home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/ogsf.h:539,
                 from gs2.c:48:
/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/defs/ogsf.h:569:6: note: in a call to function ‘gsd_real2surf’
  569 | void gsd_real2surf(geosurf *, Point3);
      |      ^~~~~~~~~~~~~
gs2.c:3297:5: error: ‘gsd_real2surf’ accessing 12 bytes in a region of size 8 [-Werror=stringop-overflow=]
 3297 |     gsd_real2surf(gs, p2);
      |     ^~~~~~~~~~~~~~~~~~~~~
gs2.c:3297:5: note: referencing argument 2 of type ‘float *’
In file included from /home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/ogsf.h:539,
                 from gs2.c:48:
/home/runner/work/grass/grass/dist.x86_64-pc-linux-gnu/include/grass/defs/ogsf.h:569:6: note: in a call to function ‘gsd_real2surf’
  569 | void gsd_real2surf(geosurf *, Point3);
      |      ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

nilason · 2023-01-04T23:16:02Z

Mhh, this triggers unrelated other issues:

Probably caused by newer and stricter version of gcc and/or glibc.

Following warnings are causing error (with -Werror):

-Wstringop-overflow=
-Warray-parameter=
-Wclass-memaccess (will be fixed with r.terraflow: use default #2660)

nilason · 2023-01-05T14:57:37Z

Mhh, this triggers unrelated other issues:

Probably caused by newer and stricter version of gcc and/or glibc.

Following warnings are causing error (with -Werror):

-Wstringop-overflow=

-Warray-parameter=

-Wclass-memaccess (will be fixed with r.terraflow: use default #2660)

-Wstringop-overflow= and -Warray-parameter= warnings will be fixed by #2733.

neteler · 2023-01-05T15:34:23Z

Thanks so much, @nilason !

neteler · 2023-01-08T11:49:57Z

Yay, also the two Ubuntu CI runs finished successfully - no timeout!

nilason · 2023-01-13T11:12:17Z

Currently the Ubuntu based builds are failing badly, just restarted 'GCC' to see if this PR has the same issue. Indeed it has.

neteler · 2023-01-13T15:48:05Z

...
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/p/proj/proj-bin_8.2.1-1_amd64.deb  Unable to connect to azure.archive.ubuntu.com:http: [IP: 52.252.75.106 80]
...

:-(

nilason · 2023-01-13T17:08:01Z

actions/runner-images#6911 looks like being related to this.

nilason · 2023-01-13T17:17:56Z

Both Ubuntu 20.04 and 22.04 images were updated Jan 9:
https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20230109.1
https://github.com/actions/runner-images/releases/tag/ubuntu20%2F20230109.1

nilason · 2023-01-13T17:20:34Z

Or this actions/runner-images#6913

nilason · 2023-01-13T18:05:10Z

By the look of it, it works again.

neteler · 2023-01-23T16:28:55Z

Any objections to merge this PR?

nilason · 2023-01-23T16:45:17Z

I have no objections, we have the CentOS runner for testing on older systems, no?. If this indeed solves the timeout issues -- even better.

neteler · 2023-01-23T16:53:52Z

we have the CentOS runner for testing on older systems, no?

Yes and no:

However, we will check if the code compiles on the older Centos runner while - with this PR - running the tests on the recent Ubuntu runner which doesn't timeout. And keeping the old Ubuntu runner which mostly time-outs doesn't help much.

nilason · 2023-01-23T17:57:15Z

Fair enough. Maybe we can try this for some time, to see if it consistently works on a newer system and revert to the 20.04 if it doesn't.

neteler · 2023-01-23T22:16:25Z

So, let's try! Merging...

* GitHub actions: update to current versions The GHA `ci.yml` and others show the warning _Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2, r-lib/actions/setup-r@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/._ Additionally: - update the various actions - updates ubuntu-20.04 to ubuntu-22.04 (see also OSGeo/grass#2730) - sync Python to v3.10 - updates to super-linter:v4 - super-linter: enable markdown linting - use the real super-linter action instead of a container - super-linter.yml: do not mix VALIDATE=true and VALIDATE=false Co-authored-by: Nicklas Larsson <[email protected]> Co-authored-by: Edouard Choinière <[email protected]>

Since the older ubuntu-20.04 image based runs commonly time-out: * update to the current ubuntu-22.04 image * rename scripts to reflect usage of ubuntu-22.04 image

* GitHub actions: update to current versions The GHA `ci.yml` and others show the warning _Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2, r-lib/actions/setup-r@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/._ Additionally: - update the various actions - updates ubuntu-20.04 to ubuntu-22.04 (see also OSGeo/grass#2730) - sync Python to v3.10 - updates to super-linter:v4 - super-linter: enable markdown linting - use the real super-linter action instead of a container - super-linter.yml: do not mix VALIDATE=true and VALIDATE=false Co-authored-by: Nicklas Larsson <[email protected]> Co-authored-by: Edouard Choinière <[email protected]>

Since the older ubuntu-20.04 image based runs commonly time-out: * update to the current ubuntu-22.04 image * rename scripts to reflect usage of ubuntu-22.04 image

CI: attempt with ubuntu-22.04 image

3d68534

Since the older ubuntu-20.04 image based runs commonly time-out, here an attempt with the current ubuntu-22.04 image.

neteler added the CI Continuous integration label Jan 4, 2023

neteler added this to the 8.3.0 milestone Jan 4, 2023

neteler self-assigned this Jan 4, 2023

rename scripts to reflect usage of ubuntu-22.04 image

62a07f8

nilason mentioned this pull request Jan 5, 2023

checks: Fix Wstringop-overflow and -Warray-parameter compiler warnings #2733

Merged

neteler added 2 commits January 7, 2023 18:01

Merge branch 'main' into ci_ubuntu-22.04_image

85a3d71

merge in #2734

196eefb

neteler changed the title ~~CI: attempt with ubuntu-22.04 image~~ CI: attempt with ubuntu-22.04 image to avoid timeout Jan 8, 2023

neteler requested a review from wenzeslaus January 10, 2023 09:38

This was referenced Jan 18, 2023

GitHub actions: update to current versions OSGeo/grass-addons#847

Merged

CI: chore(deps): update docker/build-push-action action to v3 #2776

Merged

CI: chore(deps): update docker/login-action action to v2 #2777

Merged

neteler changed the title ~~CI: attempt with ubuntu-22.04 image to avoid timeout~~ CI: switch to ubuntu-22.04 image to avoid timeout Jan 23, 2023

neteler merged commit 4a68d5a into OSGeo:main Jan 23, 2023

neteler deleted the ci_ubuntu-22.04_image branch January 23, 2023 22:17

wenzeslaus mentioned this pull request Mar 22, 2023

g.extension: use git sparse-checkout instead of SVN #2895

Merged

Uh oh!

Comments

Conversation

neteler commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neteler commented Jan 4, 2023

Uh oh!

nilason commented Jan 4, 2023

Uh oh!

nilason commented Jan 5, 2023

Uh oh!

neteler commented Jan 5, 2023

Uh oh!

neteler commented Jan 8, 2023

Uh oh!

nilason commented Jan 13, 2023

Uh oh!

neteler commented Jan 13, 2023

Uh oh!

nilason commented Jan 13, 2023

Uh oh!

nilason commented Jan 13, 2023

Uh oh!

nilason commented Jan 13, 2023

Uh oh!

nilason commented Jan 13, 2023

Uh oh!

neteler commented Jan 23, 2023

Uh oh!

nilason commented Jan 23, 2023

Uh oh!

neteler commented Jan 23, 2023

Uh oh!

nilason commented Jan 23, 2023

Uh oh!

neteler commented Jan 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

neteler commented Jan 4, 2023 •

edited

Loading