startup: catch errors in build_modules_xml.py, grass.py#2686
Merged
neteler merged 2 commits intoOSGeo:mainfrom Feb 13, 2023
neteler:python_scripterror_catch
Merged
startup: catch errors in build_modules_xml.py, grass.py#2686neteler merged 2 commits intoOSGeo:mainfrom neteler:python_scripterror_catch
neteler merged 2 commits intoOSGeo:mainfrom
neteler:python_scripterror_catch
Conversation
This PR is an extract from #348: - gui/wxpython/tools/build_modules_xml.py edits: https://github.com/OSGeo/grass/pull/348/files#diff-11ca77721b6d009b6537c54be4172efed843021797676258ad1141a6c63e6fd1 - lib/init/grass.py: https://github.com/OSGeo/grass/pull/348/files#diff-647be4ef599868c33f2f69f0d899f79f0aee8d75d1db74f523268c1ac94cddf7 Not sure if we want these changes but just to avoid to see them lost when closing #348 in favour of #2684.
neteler
added
enhancement
wenzeslaus
requested changes
Dec 23, 2022
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Generally, this looks good.
I'm not sure about managing these small changes smartly for the release notes. It does not fit into these categories:
Co-authored-by: Vaclav Petras <[email protected]>
neteler
changed the title
Member
Author
I have changed to use the "startup: ..." keyword. |
Member
Author
|
@wenzeslaus may I merge this PR? Not sure how to properly dismiss the "Changes requested" which I believe have been addressed. |
wenzeslaus
approved these changes
Feb 13, 2023
Member
|
Dismiss review is in the details of the "change requested" section under the The failure from Ubuntu / minimum config tests is unrelated to this PR (the old run cannot be restarted anymore). |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
* build_modules_xml.py, grass.py: catch errors This PR is an extract from OSGeo#348: - gui/wxpython/tools/build_modules_xml.py edits: https://github.com/OSGeo/grass/pull/348/files#diff-11ca77721b6d009b6537c54be4172efed843021797676258ad1141a6c63e6fd1 - lib/init/grass.py: https://github.com/OSGeo/grass/pull/348/files#diff-647be4ef599868c33f2f69f0d899f79f0aee8d75d1db74f523268c1ac94cddf7
neteler
added a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* build_modules_xml.py, grass.py: catch errors This PR is an extract from OSGeo#348: - gui/wxpython/tools/build_modules_xml.py edits: https://github.com/OSGeo/grass/pull/348/files#diff-11ca77721b6d009b6537c54be4172efed843021797676258ad1141a6c63e6fd1 - lib/init/grass.py: https://github.com/OSGeo/grass/pull/348/files#diff-647be4ef599868c33f2f69f0d899f79f0aee8d75d1db74f523268c1ac94cddf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an extract from #348 (extracted and updated with
black):Not sure if we want these changes but just to avoid to see them lost when closing #348 in favour of #2684.