Skip to content

Comments

wxGUI/psmap: fix show correct error message if Ghostscript isn't installed (required for rendering output PDF file) on the OS MS Windows platform#2420

Merged
tmszi merged 5 commits intoOSGeo:mainfrom
tmszi:wxgui_psmap_fix_find_gs_exec
Sep 28, 2023
Merged

Conversation

@tmszi
Copy link
Member

@tmszi tmszi commented Jun 8, 2022

Describe the bug
Wrong error message if Ghostscript gswin32c/gswin64c isn't installed (required for rendering output PDF file) on the OS MS Windows platform

To Reproduce
Steps to reproduce the behavior:

  1. Download and install e.g. WinGRASS-8.3.dev
  2. Launch wxGUI Cartographic Composer g.gui.psmap
  3. Add Map frame and choose some raster map e.g. elevation
  4. Push toolbar Generate PDF output tool
  5. See error

wxGUI_psmap_error_message_dialog_def

Expected behavior
If Ghostscript gswin32c/gswin64c isn't installed (required for rendering output PDF file), show correct error message.

wxGUI_psmap_error_message_dialog_expected

System description:

  • Operating System: MS Windows
  • GRASS GIS version: all versions

@tmszi tmszi added bug Something isn't working windows Microsoft Windows specific GUI wxGUI related labels Jun 8, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jun 8, 2022
petrasovaa
petrasovaa reviewed Jun 10, 2022
View reviewed changes
petrasovaa
petrasovaa reviewed Jun 10, 2022
View reviewed changes
petrasovaa
petrasovaa reviewed Jun 10, 2022
View reviewed changes
@tmszi
Copy link
Member Author

tmszi commented Jun 10, 2022

All right, I fixed it.

@petrasovaa
Copy link
Contributor

petrasovaa commented Jun 10, 2022

All right, I fixed it.

I apologize, looking at it again, I gave you a wrong suggestion, the translation doesn't work with f-strings so you will need to use a format function as before:
_(xxxx {yyyy} xxx).format(...)

@tmszi
Copy link
Member Author

tmszi commented Jun 11, 2022

All right, I fixed it.

I apologize, looking at it again, I gave you a wrong suggestion, the translation doesn't work with f-strings so you will need to use a format function as before: _(xxxx {yyyy} xxx).format(...)

Okay, I fixed it.

petrasovaa
petrasovaa approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tmszi
Copy link
Member Author

tmszi commented Jun 19, 2022

@petrasovaa Maybe should be better use HyperlinkDialog if Ghostscript is not available (for rendering PDF), same as in PR #2421 (for rendering preview) with same simplified error message?

@petrasovaa
Copy link
Contributor

petrasovaa commented Oct 21, 2022

@petrasovaa Maybe should be better use HyperlinkDialog if Ghostscript is not available (for rendering PDF), same as in PR #2421 (for rendering preview) with same simplified error message?

I agree, but I will leave it up to you if you want to change that.

@neteler neteler modified the milestones: 8.2.1, 8.2.2 Jan 22, 2023
@wenzeslaus wenzeslaus modified the milestones: 8.2.2, 8.3.1 Jun 6, 2023
@tmszi
wxGUI/psmap: fix show correct error message if Ghostscript isn't inst…
ac3ee59 
…alled

If Ghostscript (required for rendering output PDF file) isn't
installed on the OS MS Windows platform show correct error message.
@tmszi
Incorporate suggestions
eaa596e
@tmszi
Use format() func instead of f-string
d0cc130
@tmszi
Use HyperlinkDialog instead of GError dialog
7540bf1
@tmszi tmszi force-pushed the wxgui_psmap_fix_find_gs_exec branch from 47b8b86 to 7540bf1 Compare September 27, 2023 10:04
@tmszi
Copy link
Member Author

tmszi commented Sep 27, 2023

Rebase 7540bf1 plus replace GError dialog with HyperlinkDialog.

petrasovaa
petrasovaa reviewed Sep 28, 2023
View reviewed changes
@tmszi tmszi merged commit 5569b00 into OSGeo:main Sep 28, 2023
tmszi added a commit to tmszi/grass that referenced this pull request Sep 28, 2023
@tmszi
wxGUI/psmap: fix show correct error message if Ghostscript isn't inst…
c0bf403 
…alled (OSGeo#2420)

If Ghostscript (required for rendering output PDF file) isn't
installed on the OS MS Windows platform show correct error message.
tmszi added a commit to tmszi/grass that referenced this pull request Sep 28, 2023
@tmszi
wxGUI/psmap: fix show correct error message if Ghostscript isn't inst…
d52aa02 
…alled (OSGeo#2420)

If Ghostscript (required for rendering output PDF file) isn't
installed on the OS MS Windows platform show correct error message.
@tmszi tmszi deleted the wxgui_psmap_fix_find_gs_exec branch September 28, 2023 18:35
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
@tmszi @landam
wxGUI/psmap: fix show correct error message if Ghostscript isn't inst…
b6a201a 
…alled (OSGeo#2420)

If Ghostscript (required for rendering output PDF file) isn't
installed on the OS MS Windows platform show correct error message.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@tmszi @neteler
wxGUI/psmap: fix show correct error message if Ghostscript isn't inst…
59e56fa 
…alled (OSGeo#2420)

If Ghostscript (required for rendering output PDF file) isn't
installed on the OS MS Windows platform show correct error message.
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
@tmszi @HuidaeCho
wxGUI/psmap: fix show correct error message if Ghostscript isn't inst…
39e51dd 
…alled (OSGeo#2420)

If Ghostscript (required for rendering output PDF file) isn't
installed on the OS MS Windows platform show correct error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees

No one assigned

Labels

bug Something isn't working GUI wxGUI related windows Microsoft Windows specific

Projects

None yet

Milestone

8.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@tmszi @petrasovaa @neteler @wenzeslaus @landam