Skip to content

Comments

configure: update to autoconf 2.71#2281

Merged
nilason merged 5 commits intoOSGeo:mainfrom
nilason:configure-update-to-autoconf271
Dec 22, 2023
Merged

configure: update to autoconf 2.71#2281
nilason merged 5 commits intoOSGeo:mainfrom
nilason:configure-update-to-autoconf271

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Mar 26, 2022 •
edited
Loading

Update GRASS configure to autoconf 2.71 (from present 2.69).

From autoconf 2.70 announcement:

We are pleased to announce stable release 2.70 of GNU Autoconf.

This release includes eight years of development work since the
previous release, 2.69. Noteworthy changes include support for the
2011 revisions of the C and C++ standards, support for reproducible
builds, improved support for cross-compilation, improved compatibility
with current compilers and shell utilities, more efficient generated
shell code, and many bug fixes.

(see more)

Announcement of 2.71:

We are pleased to announce stable release 2.71 of Autoconf.

2.71 is a bugfix release, correcting several important compatibility
problems and regressions discovered since the release of 2.70. There
are no new features. Upgrading is recommended for all users of 2.70.
Users of 2.69 or earlier should proceed with caution; please consult
the NEWS file and/or the release announcement for 2.70 for details.

This is a smaller jump than the one from 2.13 to 2.69 (#1845), and (hopefully) avoids issues with patched distributions of autoconf, e.g. #2225 and #2280.

autoconf 2.71 News

@nilason nilason added this to the 8.4.0 milestone Mar 26, 2022
@nilason nilason added the enhancement New feature or request label Mar 26, 2022
@metzm
Copy link
Contributor

metzm commented Mar 27, 2022

Current stable releases of e.g. Debian and Fedora come with autoconf 2.69. I suggest to wait with this PR until these two important Linux distros provide autoconf 2.71 in their latest stable releases.

@nilason
Copy link
Contributor Author

nilason commented Mar 28, 2022

Current stable releases of e.g. Debian and Fedora come with autoconf 2.69. I suggest to wait with this PR until these two important Linux distros provide autoconf 2.71 in their latest stable releases.

This is not an urgent issue. I was foremost curious how much changes was needed to update and apparently there was not much. All the same, I tagged this to 8.4 and had no intention to suggest to backport it.

@neteler
Copy link
Member

neteler commented Aug 28, 2022

Current stable releases of e.g. Debian and Fedora come with autoconf 2.69. I suggest to wait with this PR until these two important Linux distros provide autoconf 2.71 in their latest stable releases.

I just checked https://repology.org/project/autoconf/versions :

  • Debian 11 (bullseye - official): autoconf 2.69
  • Debian 12 (bookworm - in testing): autoconf 2.71
  • Fedora 36 (official): autoconf 2.71
  • Ubuntu 22.04 (testing): autoconf 2.69
  • Ubuntu 22.10 (testing): autoconf 2.71

@nilason nilason mentioned this pull request Feb 8, 2023
Closed
@nilason nilason modified the milestones: 8.3.0, 8.4.0 Feb 14, 2023
@a-detiste
Copy link
Contributor

a-detiste commented Aug 8, 2023

bookworm as been released

@nilason nilason mentioned this pull request Oct 5, 2023
Closed
@landam landam requested review from metzm and neteler November 20, 2023 17:48
@landam
Copy link
Member

landam commented Nov 20, 2023

@nilason Please can you rebase this PR?

@neteler neteler assigned nilason and unassigned neteler Dec 7, 2023
@nilason
Copy link
Contributor Author

nilason commented Dec 7, 2023

@nilason Please can you rebase this PR?

I will as soon as #2189 is merged. The two may conflict.

@marisn
Copy link
Contributor

marisn commented Dec 8, 2023

@nilason Please can you rebase this PR?

I will as soon as #2189 is merged. The two may conflict.

#2189 is stuck as requires @wenzeslaus approval to get merged. I'll be mostly off starting from the next week thus (unless someone else merges it), no action till the new year.

@nilason
Copy link
Contributor Author

nilason commented Dec 8, 2023

@nilason Please can you rebase this PR?

I will as soon as #2189 is merged. The two may conflict.

#2189 is stuck as requires @wenzeslaus approval to get merged. I'll be mostly off starting from the next week thus (unless someone else merges it), no action till the new year.

If it's okey with you, I'll go ahead with the rebase (and possibly merge if so agreed).

@marisn
Copy link
Contributor

marisn commented Dec 8, 2023

If it's okey with you, I'll go ahead with the rebase (and possibly merge if so agreed).

Yes, feel free to do so. I'll manage with merging changes into #2189 (and, hopefully, one day be able to merge it too).

@nilason
Copy link
Contributor Author

nilason commented Dec 11, 2023

Rebased. Looks good overall, but Travis' Clang build fails. Seems unrelated to me... clang --version fails due to missing clang, just before configure...

@nilason
Copy link
Contributor Author

nilason commented Dec 11, 2023

Rebased. Looks good overall, but Travis' Clang build fails. Seems unrelated to me... clang --version fails due to missing clang, just before configure...

There is a new Travis docker build, created in Dec 7.

@nilason
Copy link
Contributor Author

nilason commented Dec 11, 2023

Ahh, Travis is a good boy again.

@nilason
Copy link
Contributor Author

nilason commented Dec 12, 2023

According to https://repology.org/project/autoconf/versions autoconf version 2.71 is the default on following systems:

  • Debian 12 'bookworm'
  • Fedora 36
  • Ubuntu 22.04 'jammy'

I believe the day has come to upgrade and merge this PR.

Note: autoconf (with this change, version 2.71) is only needed for (re-)generating the configure file, it is not needed for building. However, if there is any package system that regenerate the configure file as part of the building, it might cause problems, but I'm not aware of any such system.

Although the changes are small, it is preferable to merge this in good time before next release, to be able to test it properly.

wenzeslaus
wenzeslaus approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really judge the details, but overall this looks hopeful and checks are passing. I like the use of #error instead of raw text choke me in the code.

@nilason
Copy link
Contributor Author

nilason commented Dec 22, 2023

@metzm, @neteler, others: any objection to merge this?

neteler
neteler approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@landam
Copy link
Member

landam commented Dec 22, 2023

@nilason Please free to merge this PR (there are already three approvals)...

@nilason nilason merged commit 31bd07a into OSGeo:main Dec 22, 2023
@echoix
Copy link
Member

echoix commented Dec 22, 2023

I had maybe one last question, but it got merged when writing the question.

Where the changes in i.cluster/global.h intended in this PR (to fix something), or was a merge/rebase artifact? I didn't read a mention of it in this thread

@nilason
Copy link
Contributor Author

nilason commented Dec 22, 2023

Where the changes in i.cluster/global.h intended in this PR (to fix something), or was a merge/rebase artifact? I didn't read a mention of it in this thread

It was intended, obsolete configure tests/macros with 2.71.

@echoix
Copy link
Member

echoix commented Dec 22, 2023

Perfect then!

@echoix echoix mentioned this pull request Dec 22, 2023
Merged
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
@nilason @HuidaeCho
configure: update to autoconf 2.71 (OSGeo#2281)
1dc5d92
@nilason nilason deleted the configure-update-to-autoconf271 branch May 15, 2024 09:40
@marisn marisn mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neteler neteler neteler approved these changes

@wenzeslaus wenzeslaus wenzeslaus approved these changes

@landam landam landam approved these changes

@metzm metzm Awaiting requested review from metzm

Assignees

@nilason nilason

Labels

enhancement New feature or request

Projects

None yet

Milestone

8.4.0

Development

Successfully merging this pull request may close these issues.

8 participants

@nilason @metzm @neteler @a-detiste @landam @marisn @echoix @wenzeslaus