Merged
Conversation
Contributor
|
I'm not quite sure including |
Contributor
Author
|
shall I remove it? |
Contributor
|
Please give it a try locally first with the line removed. If there are no problem, update this PR to see what the CI checks will tell us. |
Contributor
Author
|
k, it compiles and the library is fixed. 😄 |
nilason
reviewed
Mar 18, 2022
Contributor
Author
|
@nilason @neteler omitting Grass.make results in colortables dir not being packaged see comparision of resulting files |
Contributor
I'm not sure I understand what you mean. Eventual differences with the colortables dir in docs is unrelated to this Makefile (and the proposed changes of the same). That being said, |
Contributor
Author
|
@nilason your absolutely right 👍 I had a local caching issue causing that difference. |
Co-authored-by: Nicklas Larsson <[email protected]>
nilason
approved these changes
Mar 19, 2022
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 20, 2022
Almost supports GRASS 8, but not yet, due to a bug in GRASS. 3.22.5+ *does* support GRASS 8 but we can't enable it yet because of OSGeo/grass#2269 (=> unresolved SONAME dependencies) Keep an eye on that bug / a fixed GRASS release and readd support by unrestricting the dep in ${COMMON_DEPEND} once it's fixed! (No need to change the supported GRASS versions in src_configure b/c it won't find GRASS 8 with this dependency set.) Bug: OSGeo/grass#2269 Signed-off-by: Sam James <[email protected]>
Contributor
|
@neteler According to my testing, this is good to go. If you agree, please go ahead and merge. |
Member
|
No problems on Fedora 35, will merge and backport it. |
neteler
pushed a commit
that referenced
this pull request
Mar 23, 2022
* Update lib/imagery/Makefile: fix SONAME missing Fixes #2268 Co-authored-by: Nicklas Larsson <[email protected]>
|
@t0b3 could you backport this for gentoo? |
Contributor
Author
|
@neteler what would be the release date for 8.0.2? |
Contributor
Author
|
@thesamesam sure I can backport if there won't be a release these days. Would you prefer to hotfix and keep existing |
t0b3
added a commit
to t0b3/gentoo
that referenced
this pull request
Apr 16, 2022
backport OSGeo/grass#2269 Signed-off-by: Thomas Bettler <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Apr 17, 2022
backport OSGeo/grass#2269 Signed-off-by: Thomas Bettler <[email protected]> Closes: #25050 Signed-off-by: Sam James <[email protected]>
Member
We are still stuck on a couple of backports which I try to clarify by next week. Then the RC cycle may start with the final release coming in a few weeks. |
Contributor
Author
|
Thanks for your information. Good luck with the backports then. |
neteler
added a commit
that referenced
this pull request
May 9, 2022
The change implemented in #2269 actually didn't fix the SONAME problem (see issue #2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that #2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).
neteler
added a commit
that referenced
this pull request
May 9, 2022
The change implemented in #2269 actually didn't fix the SONAME problem (see issue #2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that #2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).
neteler
added a commit
that referenced
this pull request
May 9, 2022
The change implemented in #2269 actually didn't fix the SONAME problem (see issue #2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that #2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).
neteler
added a commit
that referenced
this pull request
May 9, 2022
The change implemented in #2269 actually didn't fix the SONAME problem (see issue #2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that #2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <[email protected]>
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
The change implemented in OSGeo#2269 actually didn't fix the SONAME problem (see issue OSGeo#2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that OSGeo#2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <[email protected]>
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
The change implemented in OSGeo#2269 actually didn't fix the SONAME problem (see issue OSGeo#2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that OSGeo#2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <[email protected]>
neteler
added a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
The change implemented in OSGeo#2269 actually didn't fix the SONAME problem (see issue OSGeo#2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that OSGeo#2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2268