Skip to content

Comments

checks: Fix -Wunused-function compiler warnings#2163

Merged
nilason merged 4 commits intoOSGeo:mainfrom
nilason:fix_wall_warnings_07
Nov 16, 2022
Merged

checks: Fix -Wunused-function compiler warnings#2163
nilason merged 4 commits intoOSGeo:mainfrom
nilason:fix_wall_warnings_07

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Feb 4, 2022

As reported in #2156.

Initially this is a draft, I commented in code to highlight the unused functions. We need to decide which ones to keep (in one way or other) and which ones that can be removed.

Affects:

  • include/grass/iostream

Modules

  • d.vect.thematic
  • i.segment
  • r.mapcalc

GRASS Library parts

  • lib/cairodriver
  • lib/gis
  • lib/raster3d
  • lib/vector/rtree
  • lib/vector/Vlib

@nilason nilason mentioned this pull request Feb 4, 2022
21 tasks
@nilason nilason added this to the 8.2.0 milestone Feb 4, 2022
@nilason nilason added C Related code is in C enhancement New feature or request labels Feb 4, 2022
@nilason nilason modified the milestones: 8.2.0, 8.4.0 Mar 17, 2022
@nilason nilason force-pushed the fix_wall_warnings_07 branch from a04b1c3 to f2e5cf5 Compare October 28, 2022 18:53
@nilason
Copy link
Contributor Author

nilason commented Oct 28, 2022

Rebased.

@nilason nilason marked this pull request as ready for review November 10, 2022 23:21
@nilason
Copy link
Contributor Author

nilason commented Nov 10, 2022

Opening this for review. A number of cases I choose to #if 0 …#endif out, instead of deleting. Please check if any could safely be removed.

@neteler
Copy link
Member

neteler commented Nov 11, 2022

Just checked after locally applying this PR:

  • compiles fine
  • only very few warnings are remaining in the entire code base when checking with cppcheck, great work!

@nilason
Copy link
Contributor Author

nilason commented Nov 11, 2022

Just checked after locally applying this PR:

  • compiles fine
  • only very few warnings are remaining in the entire code base when checking with cppcheck, great work!

Great, thanks for checking!

@nilason nilason merged commit bc52283 into OSGeo:main Nov 16, 2022
@nilason nilason deleted the fix_wall_warnings_07 branch November 16, 2022 11:44
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
@neteler neteler changed the title Fix -Wunused-function compiler warnings checks: Fix -Wunused-function compiler warnings Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants