checks: Fix -Wtautological-overlap-compare compiler warning#2157
checks: Fix -Wtautological-overlap-compare compiler warning#2157nilason merged 1 commit intoOSGeo:mainfrom
Conversation
|
Isn't the original code a bug? It never prints north, right? if (i == 0 && i == 360)
sprintf(buf, "north");I suggest re-framing it this PR as a bug fix for r.slope.aspect instead of a warning fix to draw attention to this issue. |
You're right, this is one of those warnings that are more than noise. |
|
@metzm Could you please check if my fix is correct. Whatever will be the solution, this have to be backported to 7.8.7 (as well as to 8.0.1). |
|
The fix is correct, please merge and backport. |
Addresses a -Wtautological-overlap-compare compiler warning.
Addresses a -Wtautological-overlap-compare compiler warning.
|
Thanks @metzm! Merged and backported to 8.0 and 7.8. |
Addresses a -Wtautological-overlap-compare compiler warning.
Addresses a -Wtautological-overlap-compare compiler warning.
Addresses a -Wtautological-overlap-compare compiler warning.
As reported in #2156.
Affects: