libdisplay: remove redundant GRASS_NOTIFY#2135
Conversation
|
It is there as one of the many attempts to improve the rendering workflow. It is not documented and not used in the code and there is no motivation in the commit message. However, I double checked and some or all (?) usage of ximgview and wxpyimgview can be broken if removed. See:
[GRASS-dev] Shell scripts, Glynn Clements, Dec 2009 (https://narkive.com/9nUlmRam.12) SIGUSR1 is used in ximgview and wxpyimgview. wxpyimgview could probably use watchdog as wxGUI is using but it may not be the same. |
|
I did see that single mention in ML, but that’s all. I’m still convinced this is a hack/debug/test thing. Besides, it is not particularly safe to pass an env var unchecked to a system call. |
|
I'm for removing it, but doesn't that mean we need to remove SIGUSR1 from in ximgview and wxpyimgview, too? Then the question is how they will update? Both ximgview and wxpyimgview stand somewhat outside of the standard system as alternatives when the main GUI or |
I agree, just initiated. |
|
Closes this in favour of #2705. |
This addresses one of the '-Wunused-result' compiler warnings reported in #2128.
The warning is caused by a call of
system(cmd)upon display driver closure, wherecmdis set by the environment variableGRASS_NOTIFY(if set). The warning in itself is not critical.This PR is a suggestion to address this warning by removing this GRASS_NOTIFY "hack" or whatever it is.
This is the only place in GRASS sources where
GRASS_NOTIFYis used at all.The big question is, is this GRASS_NOTIFY mechanism used by anyone, or any platform?
My research into the motivation of its introduction to GRASS 7.0 [1], or of any of its use, turned up empty. I assume there was a good reason for this in the transition to G7, but now? The GRASS_NOTIFY environment variable is also not documented.
[1] initially committed to trunk: https://trac.osgeo.org/grass/changeset/32602/grass/trunk/lib/raster/raster.c