configure: Fix ODBC configuration on Windows (branch 7.8)#1883
Merged
nilason merged 1 commit intoOSGeo:releasebranch_7_8from Sep 21, 2021
Merged
configure: Fix ODBC configuration on Windows (branch 7.8)#1883nilason merged 1 commit intoOSGeo:releasebranch_7_8from
nilason merged 1 commit intoOSGeo:releasebranch_7_8from
Conversation
nilason
changed the title
Contributor
Author
|
To be able to see if there are more issues with Windows down the line, I will now merge this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update to autoconf 2.69 cause configure failure for including ODBC on Windows.
Windows configure log:
This is caused by changes on how
AC_CHECK_HEADERworks, see autoconf manual.Specifically in this case, on Windows the header
<windows.h>must be included for the check to succeed.This fix has been tested on non-Windows machine, with and without ODBC; as well as on Windows CI on my fork.