Skip to content

Comments

fix #3882#161

Merged
petrasovaa merged 3 commits intoOSGeo:masterfrom
petrasovaa:fix-3882
Oct 27, 2019
Merged

fix #3882#161
petrasovaa merged 3 commits intoOSGeo:masterfrom
petrasovaa:fix-3882

Conversation

@petrasovaa
Copy link
Contributor

@petrasovaa petrasovaa commented Oct 24, 2019 •
edited
Loading

wxGUI: g.pnmcomp needs to use the same size as the indivually rendered maps

@hellik hellik self-requested a review October 24, 2019 08:26
@petrasovaa petrasovaa changed the title wxGUI: g.pnmcomp needs to use the same size as the indivually rendere… fix #3882 Oct 25, 2019
@petrasovaa
Copy link
Contributor Author

petrasovaa commented Oct 25, 2019

I only catch the weird exception, it seems to be working otherwise. I couldn't find a proper solution to this.

@petrasovaa petrasovaa requested a review from hellik October 25, 2019 01:43
@hellik
Copy link
Member

hellik commented Oct 25, 2019

tested it with a self compiled

System Info                                                                     
GRASS Version: 7.8.1dev                                                         
Code revision: 4785a5b77                                                        
Build date: 2019-10-25                                                          
Build platform: x86_64-w64-mingw32                                              
GDAL: 2.4.1                                                                     
PROJ: 5.2.0                                                                     
GEOS: 3.8.0                                                                     
SQLite: 3.29.0                                                                  
Python: 3.7.0                                                                   
wxPython: 4.0.3                                                                 
Platform: Windows-10-10.0.18362-SP0 (OSGeo4W) 

GRASS Version: 7.8.1dev                                                         
Code revision: 4785a5b77

is now also availabe in OSGeo4W (without patch of #161 )

applied changes of #161

Traceback (most recent call last):
  File "C:\OSGEO4~1\apps\grass\grass78\gui\wxpython\vdigit\t
oolbars.py", line 391, in OnAddAreaTool

self.OnAddArea(event)
  File "C:\OSGEO4~1\apps\grass\grass78\gui\wxpython\vdigit\t
oolbars.py", line 369, in OnAddArea

self.addArea, self.icons['addArea'].GetBitmap())
TypeError
:
ToolBar.SetToolNormalBitmap(): argument 2 has unexpected
type 'NoneType'

@petrasovaa
Copy link
Contributor Author

petrasovaa commented Oct 26, 2019

I found the problem (should have paid more attention to the error message). I disabled the setlocale code for windows (there doesn't seem to be any problem on linux), but I suspect there was a reason the code was there, so it needs to be tested... Specifically, the problem comes up if you switch to 3D view or digitizer.

hellik
hellik approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@hellik hellik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the changes in core/render.py, nviz/wxniz.py and vdigit/wxdisplay, vector digitzing of points, lines and areas works again.

@hellik hellik added backport_needed windows Microsoft Windows specific bug Something isn't working labels Oct 26, 2019
@petrasovaa petrasovaa merged commit f43825b into OSGeo:master Oct 27, 2019
@petrasovaa petrasovaa deleted the fix-3882 branch October 27, 2019 02:12
@petrasovaa petrasovaa mentioned this pull request Mar 25, 2020
Merged
@neteler neteler added this to the 7.8.1 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hellik hellik hellik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working windows Microsoft Windows specific

Projects

None yet

Milestone

7.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@petrasovaa @hellik @neteler