parser: Accept #-space-% to allow writing PEP8-compliant Python code#1446
Merged
wenzeslaus merged 1 commit intoOSGeo:releasebranch_7_8from Mar 16, 2021
Merged
Conversation
Accept '# %' in parser script header definition because '#%' is against PEP8 (each line of a block comment starts with a # and a single space). Only minimal changes to achive this support are included. '#%' is still supported fully supported and remains in documentation. The full switch to '# %' is left for v8. Partial backport of 6352241 (OSGeo#1287).
neteler
approved these changes
Mar 15, 2021
Member
neteler
left a comment
neteler
left a comment
There was a problem hiding this comment.
Tested with some G79 scripts, seems to work fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept '# %' in parser script header definition because '#%' is against PEP8
(each line of a block comment starts with a # and a single space).
Only minimal changes to achive this support are included.
'#%' is still supported fully supported and remains in documentation.
The full switch to '# %' is left for v8.
Partial backport of 6352241 (#1287).