Fix compiler warnings, part 12 by nilason · Pull Request #1406 · OSGeo/grass

nilason · 2021-02-26T17:22:39Z

Fixes compiler warnings:

-Wformat-overflow=

Twelfth part addressing #1247.

Modules / code parts directly affected:

lib/db/dbmi_base
lib/imagery
lib/symbol
lib/vector/Vlib
d.linegraph
d.vect
d.vect.thematic
i.maxlik
i.rectify
ps.map
r.li.daemon
r.viewshed
v.info
v.lidar.correction
v.lidar.edgedetection
v.lidar.growing
v.lidar.growing
v.outlier
v.surf.bspline
v.to.db

display/d.linegraph/main.c

display/d.vect.thematic/main.c

display/d.vect/main.c

imagery/i.maxlik/main.c

lib/imagery/list_gp.c

lib/imagery/list_subgp.c

lib/symbol/read.c

lib/vector/Vlib/field.c

lib/vector/Vlib/map.c

raster/r.li/r.li.daemon/daemon.c

nilason · 2021-03-16T14:48:48Z

Any idea how to avoid the below warning about "Uncontrolled format string" ?

I found the cause of that problem and addressed it with e673ee7. See: Code Scanning Results

I closed the issues (as resolved) where I updated with your suggestions. There remain some open, which need another round.

metzm · 2021-03-16T21:20:46Z

Any idea how to avoid the below warning about "Uncontrolled format string" ?

I found the cause of that problem and addressed it with e673ee7. See: Code Scanning Results

Nice catch, obvious now that I see it, not obvious to find, great!

vector/v.lidar.correction/main.c

Addresses -Wformat-overflow= warnings.

Addresses failure to list files with long names and -Wformat-overflow= warnings.

nilason · 2021-03-21T14:23:38Z

Updated with forced push for cleaner commit history.
Changes:

added database table buffer size to GNAME_MAX + 64.
using only snprintf, may use this as testing ground for eventually updating/removing G_snprintf
closed conversation on using GNAME_MAX + GNAME_MAX for cases of concatenate [dirname]/[dirname] (please reopen if you disagree with my explanation)

Addresses -Wformat-overflow= warnings.

Addresses failure to list files with long names and -Wformat-overflow= warnings.

Fixes -Wformat compiler warning: <format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘pdal::Dimension::Id’>

nilason · 2021-08-17T20:44:32Z

Any further thoughts on this PR? There are some (still open) discussions which I personally believe to be resolved.
Would be good to merge/address this for G8.

nilason · 2021-08-19T21:17:45Z

@wenzeslaus It would be preferable to keep the commits of this PR separate, as I did with previous similar PRs (cherry pick to local master and push), as they are not really related (only grouped together to simplify review). Do you have any suggestion as to how to proceed?

lib/imagery/list_subgp.c

lib/imagery/list_gp.c

wenzeslaus · 2021-08-20T02:21:37Z

It would be preferable to keep the commits of this PR separate, as I did with previous similar PRs

The first and last commit are so small that they could be one commit if needed. The overflow part in the two middle ones seems related to each other to me, so putting these two together would be okay. However, the i.group name ellipses changes seem to require a separate PR for the i.group commit.

(cherry pick to local master and push)

Direct pushes to the master branch are no longer possible without changing the settings. I have disabled those to avoid accidental pushes when people (with write access) confuse their remotes. (This is now set for both this and addons repo.)

as they are not really related (only grouped together to simplify review).

Whatever were the reasons to start with one PR...

Do you have any suggestion as to how to proceed?

...splitting this into multiple PRs seems to be the most straightforward way of going forward. No special merging procedures needed in that case.

Likely you know about it already, but if you are seeking a simple way for doing PRs, consider GitHub CLI (gh pr create -f).

Addresses -Wformat-overflow= warnings.

Fixes -Wformat compiler warning: <format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘pdal::Dimension::Id’>

Addresses failure to list files with long names and -Wformat-overflow= warnings.

nilason · 2021-08-23T19:01:20Z

@wenzeslaus If you are good with latest changes I will commit them through separate PRs.

wenzeslaus · 2021-08-24T02:55:10Z

If you are good with latest changes I will commit them through separate PRs.

Yes, that sounds great!

Addresses failure to list files with long names and -Wformat-overflow= warnings.

Fixes -Wformat compiler warning: <format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘pdal::Dimension::Id’>

Addresses -Wformat-overflow= warnings.

nilason mentioned this pull request Feb 27, 2021

[Feat] Fix compiler warnings #1247

Closed

27 tasks