Skip to content

Comments

Fix compiler warnings, part 7#1275

Closed
nilason wants to merge 5 commits intoOSGeo:masterfrom
nilason:fix-compiler-warnings-7
Closed

Fix compiler warnings, part 7#1275
nilason wants to merge 5 commits intoOSGeo:masterfrom
nilason:fix-compiler-warnings-7

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Jan 26, 2021

Fixes compiler warnings:

  • -Winteger-overflow
  • -Wlogical-not-parentheses
  • -Wunused-value
  • -Wwritable-strings
  • -Wundefined-inline

Seventh part addressing #1247.

There are a couple of -Wlogical-not-parentheses warnings and I'm not absolutely sure how to correctly address them. See comments in code.

Modules / code parts directly affected:

  • lib/display
  • lib/imagery
  • lib/raster3d
  • imagery/i.evapo.pm
  • raster/r.viewshed
  • vector/v.generalize
  • vector/v.in.pdal

@nilason nilason mentioned this pull request Jan 26, 2021
Closed
27 tasks
metzm
metzm reviewed Feb 4, 2021
View reviewed changes
metzm
metzm reviewed Feb 4, 2021
View reviewed changes
metzm
metzm reviewed Feb 4, 2021
View reviewed changes
metzm
metzm reviewed Feb 4, 2021
View reviewed changes
metzm
metzm reviewed Feb 4, 2021
View reviewed changes
nilason and others added 5 commits February 5, 2021 09:44
@nilason
r.viewshed: Avoid integer overflow (OSGeo#1275)
bdd341e 
Fixes -Winteger-overflow compiler warning.
@nilason
i.evapo.pm: Fix missing output description (OSGeo#1275)
465b0de 
Addresses -Wunused-value compiler warning.
@nilason
v.in.pdal: Use 'char *' for Option->answer (OSGeo#1275)
61ff2f9 
ISO C++11 does not allow conversion from string literal to 'char *'.

Addresses -Wwritable-strings compiler warnings.
@nilason
Avoid declaring extern function with inline (OSGeo#1275)
90fcd40 
Addresses -Wundefined-inline compiler warnings.

See https://gcc.gnu.org/onlinedocs/gcc/Inline.html
@nilason @metzm
Fix comparisons with 'logical not' on each side
1d8f4f0 
as it is only applied to the left side of the comparison. (OSGeo#1275)

Addresses -Wlogical-not-parentheses compiler warnings.

Co-authored-by: Markus Metz <[email protected]>
@nilason nilason force-pushed the fix-compiler-warnings-7 branch from ed3717b to 1d8f4f0 Compare February 5, 2021 08:54
@nilason nilason marked this pull request as ready for review February 5, 2021 08:55
@nilason
Copy link
Contributor Author

nilason commented Feb 5, 2021

Thanks! Implemented your suggestions and reworded commit messages.

@metzm
Copy link
Contributor

metzm commented Feb 7, 2021

Thanks! Implemented your suggestions and reworded commit messages.

Can you please resolve the conversations where you applied my suggestions? That makes the next round of review easier. Thanks!

@nilason
Copy link
Contributor Author

nilason commented Feb 8, 2021

Can you please resolve the conversations where you applied my suggestions? That makes the next round of review easier. Thanks!

Ok, I will do so.

@nilason
Copy link
Contributor Author

nilason commented Feb 9, 2021

Ready, will merge on approval.

metzm
metzm approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, thanks a lot for this PR!

nilason added a commit that referenced this pull request Feb 10, 2021
@nilason
r.viewshed: Avoid integer overflow (#1275)
dc5e3db 
Fixes -Winteger-overflow compiler warning.
nilason added a commit that referenced this pull request Feb 10, 2021
@nilason
i.evapo.pm: Fix missing output description (#1275)
d1edbdd 
Addresses -Wunused-value compiler warning.
nilason added a commit that referenced this pull request Feb 10, 2021
@nilason
v.in.pdal: Use 'char *' for Option->answer (#1275)
d9faf12 
ISO C++11 does not allow conversion from string literal to 'char *'.

Addresses -Wwritable-strings compiler warnings.
nilason added a commit that referenced this pull request Feb 10, 2021
@nilason
Avoid declaring extern function with inline (#1275)
d2ac21d 
Addresses -Wundefined-inline compiler warnings.

See https://gcc.gnu.org/onlinedocs/gcc/Inline.html
nilason added a commit that referenced this pull request Feb 10, 2021
@nilason @metzm
Fix comparisons with 'logical not' on each side
1384f52 
as it is only applied to the left side of the comparison. (#1275)

Addresses -Wlogical-not-parentheses compiler warnings.

Co-authored-by: Markus Metz <[email protected]>
@nilason
Copy link
Contributor Author

nilason commented Feb 10, 2021

Ready to merge, thanks a lot for this PR!

Merged. Thank you!

@nilason nilason closed this Feb 10, 2021
@nilason nilason deleted the fix-compiler-warnings-7 branch February 10, 2021 07:03
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
r.viewshed: Avoid integer overflow (OSGeo#1275)
954100d 
Fixes -Winteger-overflow compiler warning.
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
i.evapo.pm: Fix missing output description (OSGeo#1275)
b5803a2 
Addresses -Wunused-value compiler warning.
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
v.in.pdal: Use 'char *' for Option->answer (OSGeo#1275)
e1fad67 
ISO C++11 does not allow conversion from string literal to 'char *'.

Addresses -Wwritable-strings compiler warnings.
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
Avoid declaring extern function with inline (OSGeo#1275)
58bf029 
Addresses -Wundefined-inline compiler warnings.

See https://gcc.gnu.org/onlinedocs/gcc/Inline.html
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @metzm @marisn
Fix comparisons with 'logical not' on each side
33d7aa3 
as it is only applied to the left side of the comparison. (OSGeo#1275)

Addresses -Wlogical-not-parentheses compiler warnings.

Co-authored-by: Markus Metz <[email protected]>
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
r.viewshed: Avoid integer overflow (OSGeo#1275)
691e151 
Fixes -Winteger-overflow compiler warning.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
i.evapo.pm: Fix missing output description (OSGeo#1275)
cd618af 
Addresses -Wunused-value compiler warning.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
v.in.pdal: Use 'char *' for Option->answer (OSGeo#1275)
dccff34 
ISO C++11 does not allow conversion from string literal to 'char *'.

Addresses -Wwritable-strings compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
Avoid declaring extern function with inline (OSGeo#1275)
ac1b1f1 
Addresses -Wundefined-inline compiler warnings.

See https://gcc.gnu.org/onlinedocs/gcc/Inline.html
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @metzm @ninsbl
Fix comparisons with 'logical not' on each side
aa2a766 
as it is only applied to the left side of the comparison. (OSGeo#1275)

Addresses -Wlogical-not-parentheses compiler warnings.

Co-authored-by: Markus Metz <[email protected]>
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
r.viewshed: Avoid integer overflow (OSGeo#1275)
46b01fe 
Fixes -Winteger-overflow compiler warning.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
i.evapo.pm: Fix missing output description (OSGeo#1275)
7de9046 
Addresses -Wunused-value compiler warning.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
v.in.pdal: Use 'char *' for Option->answer (OSGeo#1275)
547cfe7 
ISO C++11 does not allow conversion from string literal to 'char *'.

Addresses -Wwritable-strings compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
Avoid declaring extern function with inline (OSGeo#1275)
60f65fe 
Addresses -Wundefined-inline compiler warnings.

See https://gcc.gnu.org/onlinedocs/gcc/Inline.html
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @metzm @ninsbl
Fix comparisons with 'logical not' on each side
f5c69b0 
as it is only applied to the left side of the comparison. (OSGeo#1275)

Addresses -Wlogical-not-parentheses compiler warnings.

Co-authored-by: Markus Metz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metzm metzm metzm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nilason @metzm @neteler