Skip to content

Comments

Fix compiler warnings, part 6#1274

Closed
nilason wants to merge 5 commits intoOSGeo:masterfrom
nilason:fix-compiler-warnings-6
Closed

Fix compiler warnings, part 6#1274
nilason wants to merge 5 commits intoOSGeo:masterfrom
nilason:fix-compiler-warnings-6

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Jan 26, 2021

Fixes compiler warnings:

  • -Wformat-extra-args
  • -Wformat-invalid-specifier
  • -Wparentheses
  • -Wparentheses-equality
  • -Wtautological-compare

Sixth part addressing #1247.

There are a couple of ambivalent cases and I'm not sure how to correctly address them. See comments.

Modules / code parts directly affected:

  • lib/dspf
  • lib/imagery/
  • lib/vector/Vlib/
  • display/d.vect.thematic
  • raster/r.compress
  • raster/r.fill.stats
  • raster/r.in.gridatb
  • raster3d/r3.info

nilason
nilason commented Jan 26, 2021
View reviewed changes
nilason
nilason commented Jan 26, 2021
View reviewed changes
@nilason nilason mentioned this pull request Jan 26, 2021
Closed
27 tasks
nilason and others added 4 commits February 15, 2021 13:57
@nilason
Use specifier to print literal % (OSGeo#1274)
3a26953 
Fixes -Wformat-invalid-specifier compiler warnings.
@nilason
Add parantheses to assignment in condition (OSGeo#1274)
62017d3 
Fixes -Wparentheses compiler warnings.
@nilason
Remove extraneous parentheses (OSGeo#1274)
ef644c5 
Fixes -Wparentheses-equality compiler warnings.
@nilason @metzm
lib/imagery: Fix file size check (OSGeo#1274)
600f908 
Fixes -Wtautological-compare compiler warning.

Co-authored-by: Markus Metz <[email protected]>
nilason added a commit to nilason/grass that referenced this pull request Feb 15, 2021
@nilason
Remove argument not used by format string (OSGeo#1274)
9e6f49c 
Fixes -Wformat-extra-args compiler warnings.
@nilason nilason force-pushed the fix-compiler-warnings-6 branch from 9ad5a7f to 9e6f49c Compare February 15, 2021 13:07
@nilason nilason marked this pull request as ready for review February 15, 2021 13:09
@nilason
Copy link
Contributor Author

nilason commented Feb 15, 2021

@metzm Added your suggestion and reworded commits.
Now remains to be decided what to do with commented out part of raster/r.fill.stats/main.c.

@nilason
Remove argument not used by format string (OSGeo#1274)
29539d6 
Fixes -Wformat-extra-args compiler warning.
@nilason nilason force-pushed the fix-compiler-warnings-6 branch from 9e6f49c to 29539d6 Compare February 21, 2021 13:37
@nilason nilason mentioned this pull request Feb 21, 2021
Merged
@nilason
Copy link
Contributor Author

nilason commented Feb 21, 2021 •
edited
Loading

I removed addressing the warning in raster/r.fill.stats/main.c :166 and put it in a new PR #1395 (draft so far).
This way we can at least move ahead with the other fixes, if it's good with you @metzm.

nilason added a commit to nilason/grass that referenced this pull request Feb 22, 2021
@nilason
Add parantheses to assignment in condition (OSGeo#1274)
735b58d 
Fixes -Wparentheses compiler warnings.
nilason added a commit to nilason/grass that referenced this pull request Feb 22, 2021
@nilason
Remove extraneous parentheses (OSGeo#1274)
2b792a8 
Fixes -Wparentheses-equality compiler warnings.
nilason added a commit to nilason/grass that referenced this pull request Feb 22, 2021
@nilason @metzm
lib/imagery: Fix file size check (OSGeo#1274)
5051c0f 
Fixes -Wtautological-compare compiler warning.

Co-authored-by: Markus Metz <[email protected]>
nilason added a commit to nilason/grass that referenced this pull request Feb 22, 2021
@nilason
Remove argument not used by format string (OSGeo#1274)
60fba0d 
Fixes -Wformat-extra-args compiler warning.
metzm
metzm approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please merge and let's move on.

nilason added a commit that referenced this pull request Feb 27, 2021
@nilason
Add parantheses to assignment in condition (#1274)
1e582d4 
Fixes -Wparentheses compiler warnings.
nilason added a commit that referenced this pull request Feb 27, 2021
@nilason
Remove extraneous parentheses (#1274)
1824514 
Fixes -Wparentheses-equality compiler warnings.
nilason added a commit that referenced this pull request Feb 27, 2021
@nilason @metzm
lib/imagery: Fix file size check (#1274)
c47f2c1 
Fixes -Wtautological-compare compiler warning.

Co-authored-by: Markus Metz <[email protected]>
nilason added a commit that referenced this pull request Feb 27, 2021
@nilason
Remove argument not used by format string (#1274)
f111963 
Fixes -Wformat-extra-args compiler warning.
@nilason
Copy link
Contributor Author

nilason commented Feb 27, 2021

Cherry picked and pushed manually.
@metzm Thanks!

@nilason nilason closed this Feb 27, 2021
@nilason nilason deleted the fix-compiler-warnings-6 branch February 27, 2021 12:14
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
Add parantheses to assignment in condition (OSGeo#1274)
ac3c806 
Fixes -Wparentheses compiler warnings.
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
Remove extraneous parentheses (OSGeo#1274)
bfb986f 
Fixes -Wparentheses-equality compiler warnings.
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @metzm @marisn
lib/imagery: Fix file size check (OSGeo#1274)
ac22182 
Fixes -Wtautological-compare compiler warning.

Co-authored-by: Markus Metz <[email protected]>
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
Remove argument not used by format string (OSGeo#1274)
8d54694 
Fixes -Wformat-extra-args compiler warning.
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
Add parantheses to assignment in condition (OSGeo#1274)
a1353d3 
Fixes -Wparentheses compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
Remove extraneous parentheses (OSGeo#1274)
c6093b5 
Fixes -Wparentheses-equality compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @metzm @ninsbl
lib/imagery: Fix file size check (OSGeo#1274)
6c06ad7 
Fixes -Wtautological-compare compiler warning.

Co-authored-by: Markus Metz <[email protected]>
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
Remove argument not used by format string (OSGeo#1274)
b18ff71 
Fixes -Wformat-extra-args compiler warning.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
Add parantheses to assignment in condition (OSGeo#1274)
9c095a0 
Fixes -Wparentheses compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
Remove extraneous parentheses (OSGeo#1274)
d7b0bf9 
Fixes -Wparentheses-equality compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @metzm @ninsbl
lib/imagery: Fix file size check (OSGeo#1274)
682a58c 
Fixes -Wtautological-compare compiler warning.

Co-authored-by: Markus Metz <[email protected]>
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
Remove argument not used by format string (OSGeo#1274)
795ccc2 
Fixes -Wformat-extra-args compiler warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metzm metzm metzm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nilason @metzm @neteler