Skip to content

Comments

Fix compiler warnings, part 4#1265

Closed
nilason wants to merge 2 commits intoOSGeo:masterfrom
nilason:fix-compiler-warnings-4
Closed

Fix compiler warnings, part 4#1265
nilason wants to merge 2 commits intoOSGeo:masterfrom
nilason:fix-compiler-warnings-4

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Jan 21, 2021

Fixes compiler warnings:

  • -Wpointer-compare
  • -Wpointer-sign
  • -Wtautological-pointer-compare

Fourth part addressing #1247.

Modules / code parts directly affected:

  • lib/cairodriver
  • lib/db/dbmi_client
  • lib/dspf
  • lib/gis
  • lib/pngdriver
  • lib/raster3d

@nilason nilason mentioned this pull request Jan 21, 2021
27 tasks
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, please merge!

@nilason nilason force-pushed the fix-compiler-warnings-4 branch from e1a2fbb to 6d7a779 Compare February 2, 2021 08:46
@nilason nilason marked this pull request as ready for review February 2, 2021 08:46
@nilason
Copy link
Contributor Author

nilason commented Feb 2, 2021

Updated lib/raster3d/open.c.
Reworded the commit msgs.
Ready for merge.

@metzm
Copy link
Contributor

metzm commented Feb 3, 2021

Updated lib/raster3d/open.c.
Reworded the commit msgs.
Ready for merge.

Please merge.

nilason added a commit that referenced this pull request Feb 4, 2021
Addresses -Wpointer-compare compiler warnings.
nilason added a commit that referenced this pull request Feb 4, 2021
@nilason
Copy link
Contributor Author

nilason commented Feb 4, 2021

Cherry picked and pushed manually.

Thanks!

@nilason nilason closed this Feb 4, 2021
@nilason nilason deleted the fix-compiler-warnings-4 branch February 4, 2021 07:45
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
Addresses -Wpointer-compare compiler warnings.
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
Addresses -Wpointer-compare compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
Addresses -Wpointer-compare compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants