Closed
Conversation
nilason
force-pushed
the
fix-compiler-warnings-3
branch
from
26ef437 to
119cdbb
Compare
metzm
reviewed
Jan 31, 2021
metzm
reviewed
Jan 31, 2021
metzm
reviewed
Jan 31, 2021
metzm
reviewed
Jan 31, 2021
Contributor
Author
|
Updated the suggested changes. Ready for review. For the time being I left the comments in code, but I will remove them before merge. |
metzm
approved these changes
Feb 1, 2021
Contributor
metzm
left a comment
metzm
left a comment
There was a problem hiding this comment.
From my side, ready to merge, thanks a lot!
Fixes -Wmacro-redefined compiler warning
…stant (OSGeo#1263) Fixes -Wnon-literal-null-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
nilason
added a commit
to nilason/grass
that referenced
this pull request
Feb 2, 2021
which will always evaluate to 'true'. Fixes -Wpointer-bool-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
nilason
force-pushed
the
fix-compiler-warnings-3
branch
from
580fd51 to
e7fba92
Compare
Contributor
Author
|
Cleaned up comments in code and reworded the commit msgs. |
which will always evaluate to 'true'. Fixes -Wpointer-bool-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
nilason
force-pushed
the
fix-compiler-warnings-3
branch
from
e7fba92 to
6998445
Compare
nilason
added a commit
that referenced
this pull request
Feb 4, 2021
Fixes -Wmacro-redefined compiler warning
nilason
added a commit
that referenced
this pull request
Feb 4, 2021
…stant (#1263) Fixes -Wnon-literal-null-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
nilason
added a commit
that referenced
this pull request
Feb 4, 2021
which will always evaluate to 'true'. Fixes -Wpointer-bool-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
Contributor
Author
|
Cherry picked and pushed manually. Thanks @metzm ! |
marisn
pushed a commit
to marisn/grass
that referenced
this pull request
Mar 22, 2021
Fixes -Wmacro-redefined compiler warning
marisn
pushed a commit
to marisn/grass
that referenced
this pull request
Mar 22, 2021
…stant (OSGeo#1263) Fixes -Wnon-literal-null-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
marisn
pushed a commit
to marisn/grass
that referenced
this pull request
Mar 22, 2021
which will always evaluate to 'true'. Fixes -Wpointer-bool-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
Fixes -Wmacro-redefined compiler warning
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
…stant (OSGeo#1263) Fixes -Wnon-literal-null-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
which will always evaluate to 'true'. Fixes -Wpointer-bool-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
Fixes -Wmacro-redefined compiler warning
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
…stant (OSGeo#1263) Fixes -Wnon-literal-null-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
which will always evaluate to 'true'. Fixes -Wpointer-bool-conversion compiler warnings. Co-authored-by: Markus Metz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compiler warnings:
Third part addressing #1247.
Please see comments in code for fixes of
-Wpointer-bool-conversionwarnings.Modules / code parts directly affected: