Fix compiler warnings, part 2 by nilason · Pull Request #1256 · OSGeo/grass

nilason · 2021-01-17T14:54:19Z

Fixes -Wformat compiler warnings.

One important culprit to these warnings was caused by bad detection of off_t print format with PRI_OFF_T.
Suggested solution works for me. I'm curious if it bears in general.

Second part addressing #1247.

Update:

The PRI_OFF_T problem seems to be Mac-only, updated accordingly.

Modules / code parts directly affected:

db/drivers/ogr
lib/vector/Vlib
raster/r.compress
raster/r.info
raster/t.terraflow
raster/r.viewshed
raster3d/r3.out.vtk
raster3d/r3.stats
tools/timer
vector/v.in.ascii
vector/v.lrs/v.lrs.create

nilason · 2021-01-17T16:50:46Z

The CIs failing because of intmax_t, will see to that ASAP.

configure.in

include/gis.h

lib/vector/Vlib/build_nat.c

raster/r.info/main.c

metzm · 2021-01-17T19:42:34Z

The CIs failing because of intmax_t, will see to that ASAP.

Use grass_int64 instead of intmax_t.

nilason · 2021-01-22T19:14:41Z

The CIs failing because of intmax_t, will see to that ASAP.

Use grass_int64 instead of intmax_t.

I restored grass_int64, but as printf() doesn't recognise that type, I use PRId64 macro for the format. Most platforms (all on CI) seem to support this.

metzm · 2021-01-27T20:30:04Z

I restored grass_int64, but as printf() doesn't recognise that type, I use PRId64 macro for the format. Most platforms (all on CI) seem to support this.

grass_int64 is not a fixed type, but a platform-specific typedef ... grass_int64 for some available 64 bit integer type. If PRId64 works across platforms, great! If need be, we can define matching macros in gis.h.

The aim to eliminate compiler warnings is great, but bear in mind that some compiler warnings are nonsense, requiring case-by-case judgement.

configure

lib/vector/Vlib/build_nat.c

raster3d/r3.out.vtk/errorHandling.c

raster3d/r3.stats/support.c

tools/timer/main.c

nilason · 2021-01-28T13:55:22Z

I restored grass_int64, but as printf() doesn't recognise that type, I use PRId64 macro for the format. Most platforms (all on CI) seem to support this.

grass_int64 is not a fixed type, but a platform-specific typedef ... grass_int64 for some available 64 bit integer type. If PRId64 works across platforms, great! If need be, we can define matching macros in gis.h.

The aim to eliminate compiler warnings is great, but bear in mind that some compiler warnings are nonsense, requiring case-by-case judgement.

PRId64 is declared in <inttypes.h> and therefore dependent on C99 support. Independent of outcome regarding statement on standard Cxx usage it may be implemented in "gis.h" as you suggested. Maybe like G_PRId64? That way it (inttypes.h) need not be included specifically when needed. If you agree, I will put up a suggestion for this.

nilason · 2021-01-28T13:56:10Z

The aim to eliminate compiler warnings is great, but bear in mind that some compiler warnings are nonsense, requiring case-by-case judgement.

I'm aware many compilation warnings are just annoyances, but if there are acceptable ways of getting rid of them, all the better.

metzm · 2021-01-29T21:10:02Z

I'm aware many compilation warnings are just annoyances, but if there are acceptable ways of getting rid of them, all the better.

I agree, and try to help to sieve through these compiler warnings. For some of these warnings, I just don't know how to get rid off them without breaking compatibility.

nilason · 2021-02-08T14:19:45Z

Updated according to your initial review.

The question on PRId64 and <inttypes.h> remains to be cleared. No need to force this, just wanted to fix the other issues.

metzm · 2021-02-08T22:14:50Z

The question on PRId64 and <inttypes.h> remains to be cleared. No need to force this, just wanted to fix the other issues.

Great, please merge! Let's leave the question on PRId64 and `<inttypes.h> for another PR until there is agreement on the dev ml.

_FILE_OFFSET_BITS is not set for Mac compiling with clang, but off_t is defined as a int64 (long long) type requiring a "lld" printf format.