Arrow: fix extension name key in field metadata#5829
Merged
rouault merged 2 commits intoOSGeo:masterfrom Jun 1, 2022
Merged
Conversation
Member
One way of checking the fix has effect is to add a new test case in autotest/ogr/ogr_arrow.py and generate a GeoArrow file with the following configuration options set:
|
Contributor
Author
|
Thanks for those pointers. Did a first attempt to add a test based on that (and verified that the test failed before the patch) |
a0x8o
pushed a commit
to a0x8o/gdal
that referenced
this pull request
Jun 6, 2022
a0x8o
pushed a commit
to a0x8o/gdal
that referenced
this pull request
Jun 10, 2022
a0x8o
pushed a commit
to a0x8o/gdal
that referenced
this pull request
Jun 15, 2022
a0x8o
pushed a commit
to a0x8o/gdal
that referenced
this pull request
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current field metadata key for the extension name is using a double colon, but that should be a single colon, see https://arrow.apache.org/docs/format/Columnar.html#extension-types
Noticed this while testing to read GDAL produced files with pyarrow with extension types registered for those "geoarrow.<geometry_type>" types (https://github.com/jorisvandenbossche/python-geoarrow/)
Tasklist
Does this require a test case?
I see that this key is actually checked for when reading, but since it also checks in the metadata for the known geometry columns (and its encoding), this ARROW:extension:name key is not required I suppose.