Skip to content

SAFE: for non-SLC products, do not report subdatasets that can't be opened#5812

Merged
rouault merged 1 commit intoOSGeo:masterfrom
rouault:safe_fix
May 31, 2022
Merged

SAFE: for non-SLC products, do not report subdatasets that can't be opened#5812
rouault merged 1 commit intoOSGeo:masterfrom
rouault:safe_fix

Conversation

@rouault
Copy link
Copy Markdown
Member

@rouault rouault commented May 29, 2022

Fixes issue reported in https://lists.osgeo.org/pipermail/gdal-dev/2022-May/055882.html

With that fix, the only reported subdatasets now are:

  SUBDATASET_1_NAME=SENTINEL1_CALIB:UNCALIB:S1A_IW_GRDH_1SDV_20220529T045822_20220529T045847_043421_052F5A_01B5.SAFE/manifest.safe:IW_VH:AMPLITUDE
  SUBDATASET_1_DESC=Single band with IW swath and VH polarization and UNCALIB calibration
  SUBDATASET_2_NAME=SENTINEL1_CALIB:UNCALIB:S1A_IW_GRDH_1SDV_20220529T045822_20220529T045847_043421_052F5A_01B5.SAFE/manifest.safe:IW_VV:AMPLITUDE
  SUBDATASET_2_DESC=Single band with IW swath and VV polarization and UNCALIB calibration
  SUBDATASET_3_NAME=SENTINEL1_CALIB:UNCALIB:S1A_IW_GRDH_1SDV_20220529T045822_20220529T045847_043421_052F5A_01B5.SAFE/manifest.safe:IW:AMPLITUDE
  SUBDATASET_3_DESC=IW swath with all polarizations (VH+VV) as bands and UNCALIB calibration

…pened

Fixes issue reported in https://lists.osgeo.org/pipermail/gdal-dev/2022-May/055882.html

With that fix, the only reported subdatasets now are:
```
  SUBDATASET_1_NAME=SENTINEL1_CALIB:UNCALIB:S1A_IW_GRDH_1SDV_20220529T045822_20220529T045847_043421_052F5A_01B5.SAFE/manifest.safe:IW_VH:AMPLITUDE
  SUBDATASET_1_DESC=Single band with IW swath and VH polarization and UNCALIB calibration
  SUBDATASET_2_NAME=SENTINEL1_CALIB:UNCALIB:S1A_IW_GRDH_1SDV_20220529T045822_20220529T045847_043421_052F5A_01B5.SAFE/manifest.safe:IW_VV:AMPLITUDE
  SUBDATASET_2_DESC=Single band with IW swath and VV polarization and UNCALIB calibration
  SUBDATASET_3_NAME=SENTINEL1_CALIB:UNCALIB:S1A_IW_GRDH_1SDV_20220529T045822_20220529T045847_043421_052F5A_01B5.SAFE/manifest.safe:IW:AMPLITUDE
  SUBDATASET_3_DESC=IW swath with all polarizations (VH+VV) as bands and UNCALIB calibration
```
@sgofferj
Copy link
Copy Markdown

@rouault Thanks for the fast reaction! However, I'd like to point out that there is calibration data also in the GRDH products, at least, corresponding XML files are present and SNAP does offer calibrated intensity bands also from GRDH products.

Here's the files which e.g. are in the annotation/calibration folder of S1A_IW_GRDH_1SDV_20220529T045822_20220529T045847_043421_052F5A_01B5.SAFE (UUID: c2380d61-207e-46c6-9ade-5cb1a0abdcd2)
calibration.zip

@rouault
Copy link
Copy Markdown
Member Author

rouault commented May 30, 2022

I'd like to point out that there is calibration data also in the GRDH products, at least, corresponding XML files are present and SNAP does offer calibrated intensity bands also from GRDH products

maybe. I'm not familiar with calibration process. If the calibration process is the same as SLC, it might be relatively straightforward to adapt the driver re-using the SLC logic, otherwise it would need more involved changes

@sgofferj
Copy link
Copy Markdown

OK. Unfortunately, that's "a little" above my skills with regards to C++ coding. How would I proceed? Would I open an issue with a feature request/suggestion?

@rouault
Copy link
Copy Markdown
Member Author

rouault commented May 30, 2022

Would I open an issue with a feature request/suggestion?

you may (but there's no guarantee someone will tackle it)

@rouault rouault merged commit 6b24c41 into OSGeo:master May 31, 2022
github-actions bot pushed a commit that referenced this pull request May 31, 2022
SAFE: for non-SLC products, do not report subdatasets that can't be opened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants