GDAL GRASS driver: add rpath to Makefile.in#5503
Conversation
|
CC @sebastic |
|
I'd rather see GRASS getting its act together and use FHS compliant paths for everything it installs thereby removing the need to set This is a simpler change that we've carried in the Debian package since before I got involved, but it's not a solution in itself. As mentioned in the grass-dev thread [2], GRASS itself doesn't set |
|
I see. In this case this PR, just like the Debian patch, does not help. A solution, as long as GRASS libraries are in non-standard directories, would be to create something like to the |
|
Adding a non-standard library path to ld.so.conf is a violation of Debian policy as also mentioned in the thread on grass-dev: For an acceptable solution either GRASS needs to set |
|
A pity. The GRASS startup mechanisms do set Therefore the only solution for the time being seems to be that users set |
|
|
|
With GRASS PR 2280 and this PR, the GDAL-GRASS plugin works without any further modifications to |
|
The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 21 days and is being automatically marked as "stale". If you think this pull request should be merged, please check - that all unit tests are passing - that all comments by reviewers have been addressed - that there is enough information for reviewers, in particular
|
|
It's more useful now that GRASS sets RUNPATH. |
|
@rouault Can this please be added to the upcoming GDAL 3.4.3? Thanks |
|
ok I'm doing it, but it should be the responsibility of contributors to ensure they have backported their changes ahead of release time (tagging their pull requests with the "backport release/XXXX" label) |
|
Thanks and sorry about not being aware of this procedure so far. |
What does this PR do?
Add
-Wl,-rpath,<path>to Makefile.in of the GDAL GRASS driver. This is supposed to be a generic solution replacing the Debian patch.The reason for this PR, as well as the Debian patch, is that GRASS shared libraries are in a non-standard location that is usually not in the common list of directories with shared libraries, also not in
/etc/ld.so.conf.d/*and not inLD_LIBRARY_PATH.