GDALWarp: Harden NoData value parsing#12198
Merged
rouault merged 8 commits intoOSGeo:masterfrom Apr 27, 2025
Merged
Conversation
rouault
reviewed
Apr 27, 2025
rouault
approved these changes
Apr 27, 2025
Collaborator
…ll become failure
rouault
force-pushed
the
warp-harden-nodata-parsing
branch
from
464bbad to
676a536
Compare
This was referenced Apr 27, 2025
QuLogic
reviewed
Sep 1, 2025
| "INIT_DEST was set to NO_DATA, but a NoData value was " | ||
| "not defined. This warning will become a failure in a " | ||
| "future GDAL release."); | ||
| return CE_Failure; |
Contributor
There was a problem hiding this comment.
Is this left-in return not still a failure instead of just a warning? At the least, it means it won't go through all the bands in the for loop it's in, nor those memset below.
This was referenced Sep 2, 2025
wietzesuijker
added a commit
to wietzesuijker/gdal
that referenced
this pull request
Feb 10, 2026
…ilure Resolves OSGeo#12210 Per OSGeo#12198, we temporarily issued a warning when INIT_DEST=NO_DATA was set without a destination nodata value, to accommodate rasterio usage. Rasterio has since fixed this (now sets INIT_DEST=0 when no nodata is defined). Change the warning to a failure and document in migration guide.
wietzesuijker
added a commit
to wietzesuijker/gdal
that referenced
this pull request
Feb 17, 2026
…ilure Resolves OSGeo#12210 Per OSGeo#12198, we temporarily issued a warning when INIT_DEST=NO_DATA was set without a destination nodata value, to accommodate rasterio usage. Rasterio has since fixed this (now sets INIT_DEST=0 when no nodata is defined). Change the warning to a failure and document in migration guide.
wietzesuijker
added a commit
to wietzesuijker/gdal
that referenced
this pull request
Feb 22, 2026
…ilure Resolves OSGeo#12210 Per OSGeo#12198, we temporarily issued a warning when INIT_DEST=NO_DATA was set without a destination nodata value, to accommodate rasterio usage. Rasterio has since fixed this (now sets INIT_DEST=0 when no nodata is defined). Change the warning to a failure and document in migration guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-srcnodataand-dstnodatacannot be parsedINIT_DESTcannot be parsedINIT_DEST=NO_DATAwithout a NoData value, to accommodate rasterio usage